don't send Content-Type or Content-Length for 304

[chadwhitacre]

Got burned by this on gratipay/gratipay.com#1308.

[chadwhitacre]

The spec actually says not to send most entity-headers for 304:

http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3.5

The entity headers are listed here:

http://www.w3.org/Protocols/rfc2616/rfc2616-sec7.html#sec7.1

[pjz]

So... we don't. In fact, we basically only send the Location header (plus any the developer provides) if you call request.redirect(). The bug in gratipay/gratipay.com#1308 is in your cache_static code (which, yes, should maybe be moved upstream into aspen, but isn't, as of yet)

So this isn't actually an aspen bug.

[chadwhitacre]

IRC

tl;dr : 0.25.3 might have fixed this already.

[chadwhitacre]

I believe this is accidentally implemented as a side-effect of 64b9208 (cf. gratipay/gratipay.com#1449). We should write a couple tests to be sure and then close.

[chadwhitacre]

@pjz Could we get two tests for this if we don't have them? Then we should be able to close.

[pjz]

test_website.py has test_redirect_has_only_location, which asserts there's exactly one header returned and that it's a 'Location' header. So this should just be closed.

[chadwhitacre]

🍒