Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-a04a87739c.js Is 404'ing on the spreedsheet #217

Open
ASwoodDude opened this issue Aug 3, 2021 · 0 comments · May be fixed by #223
Open

app-a04a87739c.js Is 404'ing on the spreedsheet #217

ASwoodDude opened this issue Aug 3, 2021 · 0 comments · May be fixed by #223

Comments

@ASwoodDude
Copy link

Address 404'ing - https://spreadsheets.google.com/feeds/worksheets/1I5W-x8QOcP2siGCPIhWWzKGWt4vyBivYLbmkv_G1B24/public/full?alt=json-in-script&callback=__jsonpcallback0

kobold.club.har.txt

I've included the har file. Github apparently doesn't support .har file types so it's currently a .txt
Lnaden added a commit to Lnaden/5e-monsters that referenced this issue Aug 21, 2021
@Lnaden
Update the Google Sheets API calls to v4
76b8a79 
This PR updates the API calls to Google Sheets to use v4 instead of v3
which was shut down August 2.

Fixes Asmor#217, Fixes Asmor#218, and Fixes Asmor#222 with some caveats, see below.

Full disclosure: I have no idea what I'm doing really with JS, so there
are likely to be improvements to be made.

Potentially Outstanding Issues:
* Uses my personal API Key. Its restricted to Google Sheets API only,
  but I would prefer it be someone else's. Not really a problem right now.
* Each Sheet is loaded in full through a GET request, returned entierly
  as JSON. This results in the load being a bit slow (and a fair amount
  of data comes down, the Official is 33MB of plain text returned for
  example. The load only happens once per sheet.
* I left in all the old code where I could in case improvements can be
  made.
* I do not know JS, so any improvements, especially in the Promises
  area are likely very welcome.
@Lnaden Lnaden linked a pull request Aug 21, 2021 that will close this issue
Open
Lnaden added a commit to Lnaden/5e-monsters that referenced this issue Aug 22, 2021
@Lnaden
Update the Google Sheets API calls to v4
8886bda 
This PR updates the API calls to Google Sheets to use v4 instead of v3
which was shut down August 2.

Fixes Asmor#217, Fixes Asmor#218, and Fixes Asmor#222 with some caveats, see below.

Full disclosure: I have no idea what I'm doing really with JS, so there
are likely to be improvements to be made.

Potentially Outstanding Issues:
* Uses my personal API Key. Its restricted to Google Sheets API only,
  but I would prefer it be someone else's. Not really a problem right now.
* Each Sheet is loaded in full through a GET request, returned entierly
  as JSON. This results in the load being a bit slow (and a fair amount
  of data comes down, the Official is 33MB of plain text returned for
  example. The load only happens once per sheet.
* I left in all the old code where I could in case improvements can be
  made.
* I do not know JS, so any improvements, especially in the Promises
  area are likely very welcome.

Removed some debug lines I left in sending to console.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the Google Sheets API calls to v4 Lnaden/5e-monsters
1 participant
@ASwoodDude