Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propsal changes to methods in SessionID #89

Open
chungwong opened this issue Aug 28, 2024 · 1 comment
Open

Propsal changes to methods in SessionID #89

chungwong opened this issue Aug 28, 2024 · 1 comment

Comments

@chungwong
Copy link

At this moment, SessionID has

pub fn inner(&self) -> String

pub fn uuid(&self) -> Uuid

I believe most of the time, what inner means it the type inside. However, it is not that case for SessionID.

Does it make sense if SessionID has the following instead?

pub fn to_string(&self) -> String

pub fn inner(&self) -> Uuid
@genusistimelord
Copy link
Member

You are correct, I do have them backwards XD. If you like, I would accept a PR to change those. just make sure to add in the Readme the changes =3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants