forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keymap and tty #268
Comments
for everyone else not using french keyboard, let's say you have american "qwerty" macbook. i bet the default keymap for tty set after the install is "us" which would be also wrong. it should be "mac-us" instead. if it's not, then your keys must be badly mapped too. it should be mac-(country) like: mac-de, mac-es, mac-se, mac-uk, mac-it, mac-pl ... |
on mac-fr keymap in tty: misplaced keys:
special chars:
|
jannau
pushed a commit
that referenced
this issue
Oct 6, 2024
commit 0199d2f upstream. MSGF_LEG_MASK is laid out with INTA in bit 0, INTB in bit 1, INTC in bit 2, and INTD in bit 3. Hardware IRQ numbers start at 0, and we register PCI_NUM_INTX IRQs. So to enable INTA (aka hwirq 0) we should set bit 0. Remove the subtraction of one. This bug would cause INTx interrupts not to be delivered, as enabling INTB would actually enable INTA, and enabling INTA wouldn't enable anything at all. It is likely that this got overlooked for so long since most PCIe hardware uses MSIs. This fixes the following UBSAN error: UBSAN: shift-out-of-bounds in ../drivers/pci/controller/pcie-xilinx-nwl.c:389:11 shift exponent 18446744073709551615 is too large for 32-bit type 'int' CPU: 1 PID: 61 Comm: kworker/u10:1 Not tainted 6.6.20+ #268 Hardware name: xlnx,zynqmp (DT) Workqueue: events_unbound deferred_probe_work_func Call trace: dump_backtrace (arch/arm64/kernel/stacktrace.c:235) show_stack (arch/arm64/kernel/stacktrace.c:242) dump_stack_lvl (lib/dump_stack.c:107) dump_stack (lib/dump_stack.c:114) __ubsan_handle_shift_out_of_bounds (lib/ubsan.c:218 lib/ubsan.c:387) nwl_unmask_leg_irq (drivers/pci/controller/pcie-xilinx-nwl.c:389 (discriminator 1)) irq_enable (kernel/irq/internals.h:234 kernel/irq/chip.c:170 kernel/irq/chip.c:439 kernel/irq/chip.c:432 kernel/irq/chip.c:345) __irq_startup (kernel/irq/internals.h:239 kernel/irq/chip.c:180 kernel/irq/chip.c:250) irq_startup (kernel/irq/chip.c:270) __setup_irq (kernel/irq/manage.c:1800) request_threaded_irq (kernel/irq/manage.c:2206) pcie_pme_probe (include/linux/interrupt.h:168 drivers/pci/pcie/pme.c:348) Fixes: 9a181e1 ("PCI: xilinx-nwl: Modify IRQ chip for legacy interrupts") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sean Anderson <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Cc: [email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
at install time, the default keymap set for tty is
fr
. it is not correct, and for some reason that keymap doesn't work as it usually does on x86 linux. for example, thealt-gr
gets stuck when trying to issue key combo likeright-opt+right-shift+l
(the letter L). this combo is what is usually used to input a pipe|
. but that doesn't work with defaultfr
keymap. that combo and many others like it trigger instead a stuckalt-gr
behavior. which in turn render it very difficult to get the keyboard into a usable state. user is stuck with broken keyboard and only has option to force hard reboot. i must also mention that, with thatfr
keymap, many keys are not located where they should be on a french macbook keyboard.if user manually change default keymap to
mac-fr
instead offr
then the situation is getting better (but not completely ok). for example most keys will now be in the proper location (with the exception of<>
being swapped with#@
), but combo still won't work, and trying to input pipe|
(withright-opt+right-shift+l
will still result in keyboard getting stuck inalt-gr
mode, rendering keyboard unusable again. user has to find blindly by trial and error where are located special chars like :|
,_
,~
,[]
,\
and so on on thismac-fr
keymap. this makes it very difficult to work with keyboard on tty. which is unfortunate because, when user breaks something by error, and that can happen for a large number of reasons, he is usualy dropped on tty, tasked to fix the things he broke. but, as i've explained, the keymap situation on tty makes it another layer of complexity. first figuring how to use the keyboard with all the problem mentioned, then finally user can have a chance to try to fix things around. the problem i describe is furthermore accentuated since, the use of combo:fn+ctrl+opt+Fkeys
is what is used to swap back and forth from tty to wayland and x11. but, when using that combo, it often trigger the stuckalt-gr
behavior too.all the above report was tested on normal fedora-kde-asahi with normal setup, on a french macbookpro, 14", m2pro.
The text was updated successfully, but these errors were encountered: