-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support on macOS (via Homebrew) #29
Comments
Thanks! The first error is probably fixable by replacing the line with: std::cout << " [PASS] " << test.path() << std::endl; The second error is about a missing boost library. I don't have a MacOS OS, but I tried to build it using github action here: If you want, you can try to make it work, and let me know if you managed to do it. Diagon/.github/workflows/continuous-integration.yaml Lines 41 to 46 in 0d4a89e
The part installing boost on MacOS Diagon/.github/workflows/continuous-integration.yaml Lines 77 to 79 in 0d4a89e
|
Yes, I just checked that. The reason why Boost is not found is because Diagon doesn't use |
Indeed! If you want to give it a try on MacOS, I would merge the PR. |
Any update on this? I tried fixing it to use
|
Seems there has been some progress 🎉 Were you able to successfully build it for macOS? |
My PR was brittle to upgrades in GCC version. See comments That should do it. |
I was unable to build with the latest code and saw a link error due to stdc++fs. |
Update: I am now able to build on the CI on Linux, Windows, Mac, WebAssembly: I still need to tweak it a bit, so that I can extract the binaries produced from Mac and Windows. |
It's done: In the release, there are 3 assets for MacOS: I don't have a Mac. Could someone try one of them to confirm this is working on Mac? What are the next step to publish it to homebrew? |
Running the binary does not work on my system. Building from source for v1.0.139 does work. So good job there. Here is what I saw when running the binary.
It could be a problem with my setup, but I have boost installed via homebrew and it seems to work fine when building from source 🤷 |
One problem I see straight away is that homebrew now installs everything under |
Thanks @RobertAudi & @celie56 I tried to link against boost statically. Unfortunately, there was a bug in Boost for MacOS: Instead, I removed the "GraphPlanar" translator from MacOS for the moment. Does it fix the problem? New builds: |
Those links appear to be broken.
|
I removed the previous draft prerelease. It is no more available. However the last links should be working. |
@ArthurSonzogni The links to the builds you linked in your previous comment are no longer available, or at least I get a 404 😕 |
Okay. It looks like I need to publish the release to make the link to work. This is now fixed @RobertAudi and @celie56. See the links from: |
@ArthurSonzogni The new binary seems to work perfectly on my M1 🎉 |
Yep. Works on my machine too 👍 |
Awesome! Thanks for checking! |
Double-confirming: same here! 🙌 I think the final swoop would be getting this now into Homebrew, which means writing a PR for https://github.com/Homebrew/homebrew-core. |
Looks like it's been a while so I'd also like to lend my upvote to the imminent |
Excuse everyone: how do I run it on Mac (M1) from the .dmg? All I get is something in bin classified as "document" so cannot really run it. |
Hey @fakkoweb! I'd guess everyone just copied the executable from the mounted directory to the desired location (and ejecting it, ofc) — Do you see no binary in the mounted dir? |
Great project! It would be really nice if we had support on macOS via Homebrew, allowing users to install Diagon via
brew install diagon
.Is there anything that would prevent a build on OSX in principle? I tried to build it on OSX Big Sur 11.6 with Apple Clang 13, but no success with a first shot:
The text was updated successfully, but these errors were encountered: