We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two conditional statements always report false in bool NeuralNetwork::check_layer_type(const Layer::Type layer_type) code.
Now:
{ const Layer::Type first_layer_type = layers[0]->get_type(); if(first_layer_type != Layer::Type::Scaling2D) return false; if(first_layer_type != Layer::Type::Scaling4D) return false; }
Should be
{ const Layer::Type first_layer_type = layers[0]->get_type(); if ((first_layer_type != Layer::Type::Scaling2D) && (first_layer_type != Layer::Type::Scaling4D)) { return false; } }
The text was updated successfully, but these errors were encountered:
Today this wrong code was changed into
if(first_layer_type != Layer::Type::Scaling2D || first_layer_type != Layer::Type::Scaling4D) return false;
It still does not make sense, because absolutely any particular type would not match Scaling2D OR Scaling4D .
It should be AND ( && ) operation instead to have a special treatment for Scaling2D AND Scaling4D and different treatment for everything else.
Sorry, something went wrong.
No branches or pull requests
Two conditional statements always report false in bool NeuralNetwork::check_layer_type(const Layer::Type layer_type) code.
Now:
Should be
The text was updated successfully, but these errors were encountered: