Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT][UI] Allow dict type for invocation parameters #5992

Open
RogerHYang opened this issue Jan 10, 2025 · 0 comments
Open

[ENHANCEMENT][UI] Allow dict type for invocation parameters #5992

RogerHYang opened this issue Jan 10, 2025 · 0 comments
Labels
c/ui enhancement New feature or request

Comments

@RogerHYang
Copy link
Contributor

Currently, only string is allowed.

The following code would crash the UI because llm.invocation_parameter is not a string.

from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import SimpleSpanProcessor

endpoint = "http://127.0.0.1:4317"
tracer_provider = TracerProvider()
tracer_provider.add_span_processor(SimpleSpanProcessor(OTLPSpanExporter(endpoint)))

with tracer_provider.get_tracer(__name__).start_as_current_span("test") as span:
    span.set_attribute("openinference.span.kind", "llm")
    span.set_attribute("llm.invocation_parameters.a", 1)
    span.set_attribute("llm.invocation_parameters.b", 2)
Screenshot 2025-01-10 at 8 34 41 AM
@RogerHYang RogerHYang added bug Something isn't working triage issues that need triage labels Jan 10, 2025
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Jan 10, 2025
@RogerHYang RogerHYang added c/ui enhancement New feature or request and removed bug Something isn't working triage issues that need triage labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/ui enhancement New feature or request
Projects
Status: 📘 Todo
Development

No branches or pull requests

1 participant