Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check git configuration before exec world create #74

Open
wants to merge 1 commit into
base: daim/change_docker_compose_using_docker_api_sdk
Choose a base branch
from
Open

fix: check git configuration before exec world create #74

wants to merge 1 commit into from
+9 −2

Commits on Sep 23, 2024

  1. fix: check git configuration before exec world create (#74) 

    Closes: WORLD-1177

## Overview

When user trying to exec `world create` but git configuration `.gitconfig` for username and password is not configured it will be returned error, but the gameshard dir is already created.

The issue is because on the last step of `world create` it will exec git commit, and it will need username and email to be configured in `.gitconfig`

Solutions
Before executing `world create`, world cli will check the git configuration is configured or not. if it's not, world cli will tell the command how to configure the git config.

## Brief Changelog

- Create func for checking git configuration
- Call the function at the first execution of `world create` command

## Testing and Verifying
- Added unit test for checkGitConfig func
    @zulkhair
    zulkhair committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4401cda View commit details
    Browse the repository at this point in the history