Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re enable debug mode #69

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: re enable debug mode #69

merged 1 commit into from
Jun 21, 2024

Conversation

zulkhair
Copy link
Collaborator

@zulkhair zulkhair commented Jun 12, 2024 •
edited
Loading

Closes: WORLD-1154

Overview

Re enable debug mode with delve on world cardinal start with --debug flag

Brief Changelog

  • Re activate --debug flag
  • Add nakama-debug container to fix nakama cannot run because cardinal is not running

Testing and Verifying

  • Tested manually using world cardinal start --debug command and delve with vs code

Notes : Unit test failed because Argus-Labs/starter-game-template#51 need to be merged first and create new tag

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 12, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@zulkhair Graphite App
Copy link
Collaborator Author

zulkhair commented Jun 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite Graphite

@zulkhair zulkhair marked this pull request as ready for review June 13, 2024 02:39
smsunarto
smsunarto requested changes Jun 14, 2024
View reviewed changes
common/logger/init.go Show resolved Hide resolved
@zulkhair Graphite App
Copy link
Collaborator Author

updated and tidied up the code.

@zulkhair zulkhair requested a review from smsunarto June 14, 2024 16:33
@smsunarto
Copy link
Member

@zulkhair unit test is failing

@zulkhair
Copy link
Collaborator Author

@zulkhair unit test is failing

Yup, need to merge Argus-Labs/starter-game-template#51 first.

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (8685e76) to head (95d328e).

❗ Current head 95d328e differs from pull request most recent head a4b9120

Please upload reports for the commit a4b9120 to get more accurate results.

Files Patch % Lines
common/teacmd/docker.go 0.00% 7 Missing ⚠️
common/logger/logger.go 0.00% 2 Missing and 1 partial ⚠️
cmd/world/evm/stop.go 0.00% 1 Missing ⚠️
common/logger/init.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   37.13%   36.89%   -0.24%     
==========================================
  Files          40       40              
  Lines        1764     1740      -24     
==========================================
- Hits          655      642      -13     
+ Misses        982      973       -9     
+ Partials      127      125       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulkhair zulkhair force-pushed the daim/re_enable_debug_mode branch 2 times, most recently from 0ebd5b7 to 95d328e Compare June 20, 2024 19:10
@zulkhair zulkhair mentioned this pull request Jun 21, 2024
Closed
@smsunarto smsunarto merged commit b0fefd8 into main Jun 21, 2024
7 checks passed
@smsunarto smsunarto deleted the daim/re_enable_debug_mode branch June 21, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smsunarto smsunarto smsunarto approved these changes

@heronimus heronimus Awaiting requested review from heronimus

@rmrt1n rmrt1n Awaiting requested review from rmrt1n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zulkhair @smsunarto