Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add evm start and celestia-devnet start commands #15

Conversation

technicallyty
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high-level changes that this PR introduces

Example (remove this)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

Please pick one of the following options

This change is a trivial rework/code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@technicallyty technicallyty changed the title wip feat: add evm start and celestia-devnet start commands Nov 16, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fd8c647) 23.52% compared to head (199ef31) 26.41%.

Files Patch % Lines
cmd/world/root/doctor.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   23.52%   26.41%   +2.88%     
==========================================
  Files           3        3              
  Lines          51       53       +2     
==========================================
+ Hits           12       14       +2     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jerargus
Copy link
Contributor

jerargus commented Dec 1, 2023

Closing this PR. I incorporated these changes into: #17

@jerargus jerargus closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants