feat: world cardinal dev graceful shutdown
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait up to 10 seconds for it to quit before force quitting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 284 284
=====================================
Misses 284 284 ☔ View full report in Codecov by Sentry. |
smsunarto
changed the title
world cardinal dev graceful shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #496
What is the purpose of the change
When you run
world-cli cardinal devthen ctrl+C to quit you'll see a wierd error message about how the process already quit then the cli will display the help message.this occurs because when scott was messing with the cli he used a version of cardinal that hung during shutdown. So he used a force quit to kill it.
Now that cardinal handles shutdown properly and doesn't hang forever during start game the mechanism is now changed to wait 10 seconds and see if the cardinal shutsdown by itself. If it doesn't then force quit.