feat: add world cardinal dev command
#10
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 292 284 -8
=====================================
+ Misses 292 284 -8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Not sure if it's already sent with these commands, but sending sigterm or sigint to the running cardinal server will trigger shutdown procedures.
These shutdown procedures aren't hooked into the event system yet but this is the pathway to trigger it and to eventually get rid of that port problem.
I'm approving, but typically I would request that signal to be sent (or to verify that the signal is being sent) to properly shutdown cardinal from the cli. Then I would make some ticket to integrate eventhub into the cardinal shutdown. Actually I'll make one now.
Multiplexer is uncommon in clis. Doesn't mean it's bad though, but users are definitely more used to a UI that's more common to CLIs. This is definitely the right path to go to build this first. Should we want the multiplexer it's just a rendering loop on top of the commands you already made. |
I agree. I now prefer the traditional logging-style interface. I think i was overzealous after finding out about bubbletea |
Closes: WORLD-467
This is a simplified version of the dev command, in the future we want the multiplexer but keeping it simple for now.
What is the purpose of the change
world cardinal devcommand to run cardinal in development modeTesting and Verifying
world cardinal devCaveat