-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(redis): redis not stopped properly in dev mode (#27)
Closes: WORLD-728 ## Overview Fix redis not stopped properly when send sigint (ctrl+c) on dev mode ## Brief Changelog - Remove `cmd.Wait()` on `runCardinal` func so program will continue until signal channel is created - Add some message to the screen ## Testing and Verifying Test the program using command `world dev` and `world dev --debug` with this conditions : - all redis are stopped (both cardinal and cardinal-dev) - redis cardinal is up -> it will show message `Maybe redis cardinal docker is still up, run 'world cardinal stop' and try again` - redis cardinal-dev is up -> it will cleanup and rerun the redis again <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Improvements** - Enhanced startup messages for better user feedback during development operations. - Improved error messaging for specific Redis-related issues. - Refined error handling in the Cardinal development command for clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
- Loading branch information
Showing
3 changed files
with
13 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters