Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change: Renamed CursorResponse to PostCursorResponse #387

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Breaking Change: Renamed CursorResponse to PostCursorResponse #387

merged 1 commit into from
Jul 12, 2022

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Jul 1, 2022

Rename CursorResponse to PostCursorResponse for consistency
Refer to issue #339

@tjoubert tjoubert requested a review from DiscoPYF July 1, 2022 02:23
@DiscoPYF DiscoPYF linked an issue Jul 4, 2022 that may be closed by this pull request
Rename CursorResponse to PostCursorResponse for consistency #339
Open
DiscoPYF
DiscoPYF approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved. Thanks for taking on issues from the backlog.

As this is a breaking change, is it gonna be released in a major version, together with other breaking changes? e.g. 2.0.0

@tjoubert tjoubert merged commit 104e1ba into master Jul 12, 2022
@tjoubert tjoubert deleted the feature-3.8/DE-246-rename-cursorResponse-to-postCursorResponse branch July 25, 2022 05:07
@tjoubert tjoubert restored the feature-3.8/DE-246-rename-cursorResponse-to-postCursorResponse branch July 25, 2022 05:07
@tjoubert tjoubert deleted the feature-3.8/DE-246-rename-cursorResponse-to-postCursorResponse branch July 25, 2022 05:07
@DiscoPYF DiscoPYF added the breaking change Identify issues that contain a breaking change for existing consumer code label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF DiscoPYF approved these changes

Assignees
No one assigned
Labels
breaking change Identify issues that contain a breaking change for existing consumer code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename CursorResponse to PostCursorResponse for consistency
2 participants
@tjoubert @DiscoPYF