Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pathlib.Path instead of os.path #29

Open
snukky opened this issue Mar 19, 2021 · 4 comments
Open

Use pathlib.Path instead of os.path #29

snukky opened this issue Mar 19, 2021 · 4 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@snukky
Copy link
Contributor

snukky commented Mar 19, 2021

Following #25 (comment), we would like to switch from using os.path to pathlib.Path.

@snukky snukky added the good first issue Good for newcomers label Mar 19, 2021
@NovusEdge
Copy link

I'd like to take this one up if this issue isn't closed yet.

@cfedermann
Copy link
Collaborator

@NovusEdge Hi! If you are still interested, feel free to work on this :) Can you please add a reply to indicate yay or nay? Thanks!

Note that we are currently running submissions for WMT22, so the latest code is in the dev branch, not main.

@cfedermann cfedermann added this to the WMT22 milestone Jul 29, 2022
@cfedermann cfedermann added the wmt22 Planned for WMT22 label Jul 29, 2022
@NovusEdge
Copy link

Please assign the issue to me, so that I can proceed and work on this

@NovusEdge
Copy link

@cfedermann, I've made the changes. Please check the PR to see if everything is in order.

@cfedermann cfedermann removed the wmt22 Planned for WMT22 label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants