forked from envoyproxy/envoy
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcheck_spelling_pedantic.py
executable file
·841 lines (669 loc) · 27.8 KB
/
check_spelling_pedantic.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
#! /usr/bin/env python3
from __future__ import print_function
import argparse
import locale
import math
import os
import re
import subprocess
import sys
from functools import partial
from itertools import chain
# Handle function rename between python 2/3.
try:
input = raw_input
except NameError:
pass
try:
cmp
except NameError:
def cmp(x, y):
return (x > y) - (x < y)
CURR_DIR = os.path.dirname(os.path.realpath(__file__))
# Special comment commands control behavior. These may appear anywhere
# within a comment, but only one per line. The command applies to the
# entire line on which it appears. The "off" command disables spell
# checking until the next "on" command, or end-of-file. The
# "skip-file" command disables spell checking in the entire file (even
# previous comments). In a multi-line (/* */) comment, "skip-block"
# disables spell checking for the remainder of the comment. For
# sequences of full-line comments (only white space before a //
# comment), "skip-block" disables spell checking the sequence of
# comments is interrupted by a blank line or a line with code.
SPELLCHECK_OFF = "SPELLCHECKER(off)" # disable SPELLCHECK_ON (or EOF)
SPELLCHECK_ON = "SPELLCHECKER(on)" # (re-)enable
SPELLCHECK_SKIP_FILE = "SPELLCHECKER(skip-file)" # disable checking this entire file
SPELLCHECK_SKIP_BLOCK = "SPELLCHECKER(skip-block)" # disable to end of comment
# Single line comments: // comment OR /* comment */
# Limit the characters that may precede // to help filter out some code
# mistakenly processed as a comment.
INLINE_COMMENT = re.compile(r'(?:^|[^:"])//( .*?$|$)|/\*+(.*?)\*+/')
# Multi-line comments: /* comment */ (multiple lines)
MULTI_COMMENT_START = re.compile(r'/\*(.*?)$')
MULTI_COMMENT_END = re.compile(r'^(.*?)\*/')
# Envoy TODO comment style.
TODO = re.compile(r'(TODO|NOTE)\s*\(@?[A-Za-z0-9-]+\):?')
# Ignore parameter names in doxygen comments.
METHOD_DOC = re.compile('@(param\s+\w+|return(\s+const)?\s+\w+)')
# Camel Case splitter
CAMEL_CASE = re.compile(r'[A-Z]?[a-z]+|[A-Z]+(?=[A-Z]|$)')
# Base64: we assume base64 encoded data in tests is never mixed with
# other comments on a single line.
BASE64 = re.compile(r'^[\s*]+([A-Za-z0-9/+=]{16,})\s*$')
NUMBER = re.compile(r'\d')
# Hex: match 1) longish strings of hex digits (to avoid matching "add" and
# other simple words that happen to look like hex), 2) 2 or more two digit
# hex numbers separated by colons, 3) "0x" prefixed hex numbers of any length,
# or 4) UUIDs.
HEX = re.compile(r'(?:^|\s|[(])([A-Fa-f0-9]{8,})(?:$|\s|[.,)])')
HEX_SIG = re.compile(r'(?:\W|^)([A-Fa-f0-9]{2}(:[A-Fa-f0-9]{2})+)(?:\W|$)')
PREFIXED_HEX = re.compile(r'0x[A-Fa-f0-9]+')
UUID = re.compile(r'[A-Fa-f0-9]{8}-[A-Fa-f0-9]{4}-[A-Fa-f0-9]{4}-[A-Fa-f0-9]{4}-[A-Fa-f0-9]{12}')
BIT_FIELDS = re.compile(r'[01]+[XxYy]+')
AB_FIELDS = re.compile(r'\W([AB]+)\W')
# Matches e.g. FC00::/8 or 2001::abcd/64. Does not match ::1/128, but
# aspell ignores that anyway.
IPV6_ADDR = re.compile(r'(?:\W|^)([A-Fa-f0-9]+:[A-Fa-f0-9:]+/[0-9]{1,3})(?:\W|$)')
# Quoted words: "word", 'word', or *word*.
QUOTED_WORD = re.compile(r'((["\'])[A-Za-z0-9.:-]+(\2))|(\*[A-Za-z0-9.:-]+\*)')
# Backtick-quoted words that look like code. Note the overlap with RST_LINK.
QUOTED_EXPR = re.compile(r'`[A-Za-z0-9:()<>_.,/{}\[\]&*-]+`')
# Tuple expressions like (abc, def).
TUPLE_EXPR = re.compile(r'\([A-Za-z0-9]+(?:, *[A-Za-z0-9]+){1,}\)')
# Command flags (e.g. "-rf") and percent specifiers.
FLAG = re.compile(r'\W([-%][A-Za-z]+)')
# Bare github users (e.g. @user).
USER = re.compile(r'\W(@[A-Za-z0-9-]+)')
# RST Links (e.g. `text <https://example.com>`_, :ref:`text <internal_ref>`)
RST_LINK = re.compile(r'`([^`<])+<([^ ]+)>`')
# RST inline literals.
RST_LITERAL = re.compile(r'``.*``')
# RST code block marker.
RST_CODE_BLOCK = '.. code-block::'
# Path names.
ABSPATH = re.compile(r'(?:\s|^)((/[A-Za-z0-9_.*-]+)+)(?:\s|$)')
FILEREF = re.compile(r'(?:\s|^)([A-Za-z0-9_./-]+\.(cc|h|py|sh))(?:\s|$)')
# Ordinals (1st, 2nd, 3rd, 4th, ...)
ORDINALS = re.compile(r'([0-9]*1st|[0-9]*2nd|[0-9]*3rd|[0-9]+th)')
# Start of string indent.
INDENT = re.compile(r'^( *)')
SMART_QUOTES = {
"\u2018": "'",
"\u2019": "'",
"\u201c": '"',
"\u201d": '"',
}
# Valid dictionary words. Anything else crashes aspell.
DICTIONARY_WORD = re.compile(r"^[A-Za-z']+$")
DEBUG = 0
COLOR = True
MARK = False
def red(s):
if COLOR:
return "\33[1;31m" + s + "\033[0m"
return s
def debug(s):
if DEBUG > 0:
print(s)
def debug1(s):
if DEBUG > 1:
print(s)
class SpellChecker:
"""Aspell-based spell checker."""
def __init__(self, dictionary_file):
self.dictionary_file = dictionary_file
self.aspell = None
self.prefixes = []
self.suffixes = []
self.prefix_re = None
self.suffix_re = None
def start(self):
words, prefixes, suffixes = self.load_dictionary()
self.prefixes = prefixes
self.suffixes = suffixes
self.prefix_re = re.compile("(?:\s|^)((%s)-)" % ("|".join(prefixes)), re.IGNORECASE)
self.suffix_re = re.compile("(-(%s))(?:\s|$)" % ("|".join(suffixes)), re.IGNORECASE)
# Generate aspell personal dictionary.
pws = os.path.join(CURR_DIR, '.aspell.en.pws')
with open(pws, 'w') as f:
f.write("personal_ws-1.1 en %d\n" % (len(words)))
f.writelines(words)
# Start an aspell process.
aspell_args = ["aspell", "pipe", "--lang=en_US", "--encoding=utf-8", "--personal=" + pws]
self.aspell = subprocess.Popen(
aspell_args,
bufsize=4096,
stdin=subprocess.PIPE,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
universal_newlines=True)
# Read the version line that aspell emits on startup.
self.aspell.stdout.readline()
def stop(self):
if not self.aspell:
return
self.aspell.stdin.close()
self.aspell.wait()
self.aspell = None
def check(self, line):
if line.strip() == '':
return []
self.aspell.poll()
if self.aspell.returncode is not None:
print("aspell quit unexpectedly: return code %d" % (self.aspell.returncode))
sys.exit(2)
debug1("ASPELL< %s" % (line))
self.aspell.stdin.write(line + os.linesep)
self.aspell.stdin.flush()
errors = []
while True:
result = self.aspell.stdout.readline().strip()
debug1("ASPELL> %s" % (result))
# Check for end of results.
if result == "":
break
t = result[0]
if t == "*" or t == "-" or t == "+":
# *: found in dictionary.
# -: found run-together words in dictionary.
# +: found root word in dictionary.
continue
# & <original> <N> <offset>: m1, m2, ... mN, g1, g2, ...
# ? <original> 0 <offset>: g1, g2, ....
# # <original> <offset>
original, rem = result[2:].split(" ", 1)
if t == "#":
# Not in dictionary, but no suggestions.
errors.append((original, int(rem), []))
elif t == '&' or t == '?':
# Near misses and/or guesses.
_, rem = rem.split(" ", 1) # Drop N (may be 0).
o, rem = rem.split(": ", 1) # o is offset from start of line.
suggestions = rem.split(", ")
errors.append((original, int(o), suggestions))
else:
print("aspell produced unexpected output: %s" % (result))
sys.exit(2)
return errors
def load_dictionary(self):
# Read the custom dictionary.
all_words = []
with open(self.dictionary_file, 'r') as f:
all_words = f.readlines()
# Strip comments, invalid words, and blank lines.
words = [w for w in all_words if len(w.strip()) > 0 and re.match(DICTIONARY_WORD, w)]
suffixes = [w.strip()[1:] for w in all_words if w.startswith('-')]
prefixes = [w.strip()[:-1] for w in all_words if w.strip().endswith('-')]
# Allow acronyms and abbreviations to be spelled in lowercase.
# (e.g. Convert "HTTP" into "HTTP" and "http" which also matches
# "Http").
for word in words:
if word.isupper():
words += word.lower()
return (words, prefixes, suffixes)
def add_words(self, additions):
lines = []
with open(self.dictionary_file, 'r') as f:
lines = f.readlines()
additions = [w + os.linesep for w in additions]
additions.sort()
# Insert additions into the lines ignoring comments, suffixes, and blank lines.
idx = 0
add_idx = 0
while idx < len(lines) and add_idx < len(additions):
line = lines[idx]
if len(line.strip()) != 0 and line[0] != "#" and line[0] != '-':
c = cmp(additions[add_idx], line)
if c < 0:
lines.insert(idx, additions[add_idx])
add_idx += 1
elif c == 0:
add_idx += 1
idx += 1
# Append any remaining additions.
lines += additions[add_idx:]
with open(self.dictionary_file, 'w') as f:
f.writelines(lines)
self.stop()
self.start()
# Split camel case words and run them through the dictionary. Returns
# a replacement list of errors. The replacement list may contain just
# the original error (if the word is not camel case), may be empty if
# the split words are all spelled correctly, or may be a new set of
# errors referencing the misspelled sub-words.
def check_camel_case(checker, err):
(word, word_offset, _) = err
debug("check camel case %s" % (word))
parts = re.findall(CAMEL_CASE, word)
# Word is not camel case: the previous result stands.
if len(parts) <= 1:
debug(" -> not camel case")
return [err]
split_errs = []
part_offset = 0
for part in parts:
debug(" -> part: %s" % (part))
split_err = checker.check(part)
if split_err:
debug(" -> not found in dictionary")
split_errs += [(part, word_offset + part_offset, split_err[0][2])]
part_offset += len(part)
return split_errs
# Check for affixes and run them through the dictionary again. Returns
# a replacement list of errors which may just be the original errors
# or empty if an affix was successfully handled.
def check_affix(checker, err):
(word, word_offset, _) = err
debug("check affix %s" % (word))
for prefix in checker.prefixes:
debug(" -> try %s" % (prefix))
if word.lower().startswith(prefix.lower()):
root = word[len(prefix):]
if root != '':
debug(" -> check %s" % (root))
root_err = checker.check(root)
if not root_err:
debug(" -> ok")
return []
for suffix in checker.suffixes:
if word.lower().endswith(suffix.lower()):
root = word[:-len(suffix)]
if root != '':
debug(" -> try %s" % (root))
root_err = checker.check(root)
if not root_err:
debug(" -> ok")
return []
return [err]
# Find occurrences of the regex within comment and replace the numbered
# matching group with spaces. If secondary is defined, the matching
# group must also match secondary to be masked.
def mask_with_regex(comment, regex, group, secondary=None):
found = False
for m in regex.finditer(comment):
if secondary and secondary.search(m.group(group)) is None:
continue
start = m.start(group)
end = m.end(group)
comment = comment[:start] + (' ' * (end - start)) + comment[end:]
found = True
return (comment, found)
# Checks the comment at offset against the spell checker. Result is an array
# of tuples where each tuple is the misspelled word, it's offset from the
# start of the line, and an array of possible replacements.
def check_comment(checker, offset, comment):
# Strip smart quotes which cause problems sometimes.
for sq, q in SMART_QUOTES.items():
comment = comment.replace(sq, q)
# Replace TODO comments with spaces to preserve string offsets.
comment, _ = mask_with_regex(comment, TODO, 0)
# Ignore @param varname
comment, _ = mask_with_regex(comment, METHOD_DOC, 0)
# Similarly, look for base64 sequences, but they must have at least one
# digit.
comment, _ = mask_with_regex(comment, BASE64, 1, NUMBER)
# Various hex constants:
comment, _ = mask_with_regex(comment, HEX, 1)
comment, _ = mask_with_regex(comment, HEX_SIG, 1)
comment, _ = mask_with_regex(comment, PREFIXED_HEX, 0)
comment, _ = mask_with_regex(comment, BIT_FIELDS, 0)
comment, _ = mask_with_regex(comment, AB_FIELDS, 1)
comment, _ = mask_with_regex(comment, UUID, 0)
comment, _ = mask_with_regex(comment, IPV6_ADDR, 1)
# Single words in quotes:
comment, _ = mask_with_regex(comment, QUOTED_WORD, 0)
# RST inline literals:
comment, _ = mask_with_regex(comment, RST_LITERAL, 0)
# Mask the reference part of an RST link (but not the link text). Otherwise, check for a quoted
# code-like expression (which would mask the link text if not guarded).
comment, found = mask_with_regex(comment, RST_LINK, 0)
if not found:
comment, _ = mask_with_regex(comment, QUOTED_EXPR, 0)
comment, _ = mask_with_regex(comment, TUPLE_EXPR, 0)
# Command flags:
comment, _ = mask_with_regex(comment, FLAG, 1)
# Github user refs:
comment, _ = mask_with_regex(comment, USER, 1)
# Absolutew paths and references to source files.
comment, _ = mask_with_regex(comment, ABSPATH, 1)
comment, _ = mask_with_regex(comment, FILEREF, 1)
# Ordinals (1st, 2nd...)
comment, _ = mask_with_regex(comment, ORDINALS, 0)
if checker.prefix_re is not None:
comment, _ = mask_with_regex(comment, checker.prefix_re, 1)
if checker.suffix_re is not None:
comment, _ = mask_with_regex(comment, checker.suffix_re, 1)
# Everything got masked, return early.
if comment == "" or comment.strip() == "":
return []
# Mask leading punctuation.
if not comment[0].isalnum():
comment = ' ' + comment[1:]
errors = checker.check(comment)
# Fix up offsets relative to the start of the line vs start of the comment.
errors = [(w, o + offset, s) for (w, o, s) in errors]
# CamelCase words get split and re-checked
errors = [*chain.from_iterable(map(lambda err: check_camel_case(checker, err), errors))]
errors = [*chain.from_iterable(map(lambda err: check_affix(checker, err), errors))]
return errors
def print_error(file, line_offset, lines, errors):
# Highlight misspelled words.
line = lines[line_offset]
prefix = "%s:%d:" % (file, line_offset + 1)
for (word, offset, suggestions) in reversed(errors):
line = line[:offset] + red(word) + line[offset + len(word):]
print("%s%s" % (prefix, line.rstrip()))
if MARK:
# Print a caret at the start of each misspelled word.
marks = ' ' * len(prefix)
last = 0
for (word, offset, suggestions) in errors:
marks += (' ' * (offset - last)) + '^'
last = offset + 1
print(marks)
def print_fix_options(word, suggestions):
print("%s:" % (word))
print(" a: accept and add to dictionary")
print(" A: accept and add to dictionary as ALLCAPS (for acronyms)")
print(" f <word>: replace with the given word without modifying dictionary")
print(" i: ignore")
print(" r <word>: replace with given word and add to dictionary")
print(" R <word>: replace with given word and add to dictionary as ALLCAPS (for acronyms)")
print(" x: abort")
if not suggestions:
return
col_width = max(len(word) for word in suggestions)
opt_width = int(math.log(len(suggestions), 10)) + 1
padding = 2 # Two spaces of padding.
delim = 2 # Colon and space after number.
num_cols = int(78 / (col_width + padding + opt_width + delim))
num_rows = int(len(suggestions) / num_cols + 1)
rows = [""] * num_rows
indent = " " * padding
for idx, sugg in enumerate(suggestions):
row = idx % len(rows)
row_data = "%d: %s" % (idx, sugg)
rows[row] += indent + row_data.ljust(col_width + opt_width + delim)
for row in rows:
print(row)
def fix_error(checker, file, line_offset, lines, errors):
print_error(file, line_offset, lines, errors)
fixed = {}
replacements = []
additions = []
for (word, offset, suggestions) in errors:
if word in fixed:
# Same typo was repeated in a line, so just reuse the previous choice.
replacements += [fixed[word]]
continue
print_fix_options(word, suggestions)
replacement = ""
while replacement == "":
try:
choice = input("> ")
except EOFError:
choice = "x"
add = None
if choice == "x":
print("Spell checking aborted.")
sys.exit(2)
elif choice == "a":
replacement = word
add = word
elif choice == "A":
replacement = word
add = word.upper()
elif choice[:1] == "f":
replacement = choice[1:].strip()
if replacement == "":
print(
"Invalid choice: '%s'. Must specify a replacement (e.g. 'f corrected')." %
(choice))
continue
elif choice == "i":
replacement = word
elif choice[:1] == "r" or choice[:1] == "R":
replacement = choice[1:].strip()
if replacement == "":
print(
"Invalid choice: '%s'. Must specify a replacement (e.g. 'r corrected')." %
(choice))
continue
if choice[:1] == "R":
if replacement.upper() not in suggestions:
add = replacement.upper()
elif replacement not in suggestions:
add = replacement
else:
try:
idx = int(choice)
except ValueError:
idx = -1
if idx >= 0 and idx < len(suggestions):
replacement = suggestions[idx]
else:
print("Invalid choice: '%s'" % (choice))
fixed[word] = replacement
replacements += [replacement]
if add:
if re.match(DICTIONARY_WORD, add):
additions += [add]
else:
print(
"Cannot add %s to the dictionary: it may only contain letter and apostrophes"
% add)
if len(errors) != len(replacements):
print("Internal error %d errors with %d replacements" % (len(errors), len(replacements)))
sys.exit(2)
# Perform replacements on the line.
line = lines[line_offset]
for idx in range(len(replacements) - 1, -1, -1):
word, offset, _ = errors[idx]
replacement = replacements[idx]
if word == replacement:
continue
line = line[:offset] + replacement + line[offset + len(word):]
lines[line_offset] = line
# Update the dictionary.
checker.add_words(additions)
class Comment:
"""Comment represents a comment at a location within a file."""
def __init__(self, line, col, text, last_on_line):
self.line = line
self.col = col
self.text = text
self.last_on_line = last_on_line
# Extract comments from lines. Returns an array of Comment.
def extract_comments(lines):
in_comment = False
comments = []
for line_idx, line in enumerate(lines):
line_comments = []
last = 0
if in_comment:
mc_end = MULTI_COMMENT_END.search(line)
if mc_end is None:
# Full line is within a multi-line comment.
line_comments.append((0, line))
else:
# Start of line is the end of a multi-line comment.
line_comments.append((0, mc_end.group(1)))
last = mc_end.end()
in_comment = False
if not in_comment:
for inline in INLINE_COMMENT.finditer(line, last):
# Single-line comment.
m = inline.lastindex # 1 is //, 2 is /* ... */
line_comments.append((inline.start(m), inline.group(m)))
last = inline.end(m)
if last < len(line):
mc_start = MULTI_COMMENT_START.search(line, last)
if mc_start is not None:
# New multi-lie comment starts at end of line.
line_comments.append((mc_start.start(1), mc_start.group(1)))
in_comment = True
for idx, line_comment in enumerate(line_comments):
col, text = line_comment
last_on_line = idx + 1 >= len(line_comments)
comments.append(Comment(line=line_idx, col=col, text=text, last_on_line=last_on_line))
# Handle control statements and filter out comments that are part of
# RST code block directives.
result = []
n = 0
nc = len(comments)
while n < nc:
text = comments[n].text
if SPELLCHECK_SKIP_FILE in text:
# Skip the file: just don't return any comments.
return []
pos = text.find(SPELLCHECK_ON)
if pos != -1:
# Ignored because spellchecking isn't disabled. Just mask out the command.
comments[n].text = text[:pos] + ' ' * len(SPELLCHECK_ON) + text[pos
+ len(SPELLCHECK_ON):]
result.append(comments[n])
n += 1
elif SPELLCHECK_OFF in text or SPELLCHECK_SKIP_BLOCK in text:
skip_block = SPELLCHECK_SKIP_BLOCK in text
last_line = n
n += 1
while n < nc:
if skip_block:
if comments[n].line - last_line > 1:
# Gap in comments. We've skipped the block.
break
line = lines[comments[n].line]
if line[:comments[n].col].strip() != "":
# Some code here. We've skipped the block.
break
elif SPELLCHECK_ON in comments[n].text:
# Turn checking back on.
n += 1
break
n += 1
elif text.strip().startswith(RST_CODE_BLOCK):
# Start of a code block.
indent = len(INDENT.search(text).group(1))
last_line = comments[n].line
n += 1
while n < nc:
if comments[n].line - last_line > 1:
# Gap in comments. Code block is finished.
break
last_line = comments[n].line
if comments[n].text.strip() != "":
# Blank lines are ignored in code blocks.
if len(INDENT.search(comments[n].text).group(1)) <= indent:
# Back to original indent, or less. The code block is done.
break
n += 1
else:
result.append(comments[n])
n += 1
return result
def check_file(checker, file, lines, error_handler):
in_code_block = 0
code_block_indent = 0
num_errors = 0
comments = extract_comments(lines)
errors = []
for comment in comments:
errors += check_comment(checker, comment.col, comment.text)
if comment.last_on_line and len(errors) > 0:
# Handle all the errors in a line.
num_errors += len(errors)
error_handler(file, comment.line, lines, errors)
errors = []
return (len(comments), num_errors)
def execute(files, dictionary_file, fix):
checker = SpellChecker(dictionary_file)
checker.start()
handler = print_error
if fix:
handler = partial(fix_error, checker)
total_files = 0
total_comments = 0
total_errors = 0
for path in files:
with open(path, 'r') as f:
lines = f.readlines()
total_files += 1
(num_comments, num_errors) = check_file(checker, path, lines, handler)
total_comments += num_comments
total_errors += num_errors
if fix and num_errors > 0:
with open(path, 'w') as f:
f.writelines(lines)
checker.stop()
print(
"Checked %d file(s) and %d comment(s), found %d error(s)." %
(total_files, total_comments, total_errors))
return total_errors == 0
if __name__ == "__main__":
# Force UTF-8 across all open and popen calls. Fallback to 'C' as the
# language to handle hosts where en_US is not recognized (e.g. CI).
try:
locale.setlocale(locale.LC_ALL, 'en_US.UTF-8')
except:
locale.setlocale(locale.LC_ALL, 'C.UTF-8')
default_dictionary = os.path.join(CURR_DIR, 'spelling_dictionary.txt')
parser = argparse.ArgumentParser(description="Check comment spelling.")
parser.add_argument(
'operation_type',
type=str,
choices=['check', 'fix'],
help="specify if the run should 'check' or 'fix' spelling.")
parser.add_argument(
'target_paths', type=str, nargs="*", help="specify the files for the script to process.")
parser.add_argument(
'-d', '--debug', action='count', default=0, help="Debug spell checker subprocess.")
parser.add_argument(
'--mark', action='store_true', help="Emits extra output to mark misspelled words.")
parser.add_argument(
'--dictionary',
type=str,
default=default_dictionary,
help="specify a location for Envoy-specific dictionary words")
parser.add_argument(
'--color',
type=str,
choices=['on', 'off', 'auto'],
default="auto",
help="Controls colorized output. Auto limits color to TTY devices.")
parser.add_argument(
'--test-ignore-exts',
dest='test_ignore_exts',
action='store_true',
help="For testing, ignore file extensions.")
args = parser.parse_args()
COLOR = args.color == "on" or (args.color == "auto" and sys.stdout.isatty())
DEBUG = args.debug
MARK = args.mark
paths = args.target_paths
if not paths:
paths = ['./api', './include', './source', './test', './tools']
# Exclude ./third_party/ directory from spell checking, even when requested through arguments.
# Otherwise git pre-push hook checks it for merged commits.
paths = [path for path in paths if not path.startswith('./third_party/')]
exts = ['.cc', '.h', '.proto']
if args.test_ignore_exts:
exts = None
target_paths = []
for p in paths:
if os.path.isdir(p):
for root, _, files in os.walk(p):
target_paths += [
os.path.join(root, f)
for f in files
if (exts is None or os.path.splitext(f)[1] in exts)
]
if os.path.isfile(p) and (exts is None or os.path.splitext(p)[1] in exts):
target_paths += [p]
rv = execute(target_paths, args.dictionary, args.operation_type == 'fix')
if args.operation_type == 'check':
if not rv:
print(
"ERROR: spell check failed. Run 'tools/spelling/check_spelling_pedantic.py fix and/or add new "
"words to tools/spelling/spelling_dictionary.txt'")
sys.exit(1)
print("PASS")