Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playlist to another modal shows source playlist name #249

Open
AntonioMrtz opened this issue Oct 6, 2024 · 1 comment
Open

Add playlist to another modal shows source playlist name #249

AntonioMrtz opened this issue Oct 6, 2024 · 1 comment
Labels
bug Something isn't working frontend Frontend related issues good first issue Good for newcomers hacktoberfest hacktoberfest help-wanted Help is wanted javascript Pull requests that update Javascript code react Pull requests that update React code typescript Pull requests that update TypeScript code

Comments

@AntonioMrtz
Copy link
Owner

AntonioMrtz commented Oct 6, 2024 •
edited
Loading

Describe the bug
While adding a playlist content to another we can select source playlist as destination

To Reproduce

  1. As user, create 2 playlists, let's say src and dst
  2. In Sidebar right click on Playlist src, then open context menu with right click
  3. Select option Añadir a playlist
  4. Possible destination will show up, you will see src Playlist included

Expected behavior

Do not show src playlist when trying to add Playlist src to dst

Screenshots

Additional context

Logic is inside ContextMenuPlaylist.tsx -> handleAddPlaylistToPlaylist. Filter request incoming playlist and do not show src to the user

🖐️ Learn how to CONTRIBUTE, all help is welcomed :)

📚 Check out the project documentation for more info

⭐ Help this project grow by giving it a star if you like it!

😵 Trello links are used for traceability, do not ask to join the board before leaving a comment in the related issue
@AntonioMrtz AntonioMrtz added bug Something isn't working good first issue Good for newcomers frontend Frontend related issues help-wanted Help is wanted labels Oct 6, 2024
@AntonioMrtz
Copy link
Owner Author

Add playlist to other playlist shows the src playlist

@AntonioMrtz AntonioMrtz pinned this issue Oct 6, 2024
@AntonioMrtz AntonioMrtz added javascript Pull requests that update Javascript code hacktoberfest hacktoberfest labels Oct 13, 2024
@AntonioMrtz AntonioMrtz unpinned this issue Oct 16, 2024
@AntonioMrtz AntonioMrtz pinned this issue Oct 16, 2024
@AntonioMrtz AntonioMrtz changed the title Frontend add Playlist to another shows source Playlist Add playlist to another modal shows source playlist name Feb 9, 2025
@AntonioMrtz AntonioMrtz added react Pull requests that update React code typescript Pull requests that update TypeScript code labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Frontend related issues good first issue Good for newcomers hacktoberfest hacktoberfest help-wanted Help is wanted javascript Pull requests that update Javascript code react Pull requests that update React code typescript Pull requests that update TypeScript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AntonioMrtz