Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename property and increase stream history length #228

Open
AntonioMrtz opened this issue Sep 25, 2024 · 4 comments
Open

Rename property and increase stream history length #228

AntonioMrtz opened this issue Sep 25, 2024 · 4 comments
Labels
backend Backend related issues frontend Frontend related issues good first issue Good for newcomers help-wanted Help is wanted python Pull requests that update Python code refactor Code changes or improvements that do not change code behaviour

Comments

@AntonioMrtz
Copy link
Owner

AntonioMrtz commented Sep 25, 2024 •
edited
Loading

Description

Extend current size of playback history to 50 songs. Rename playback_history attribute and docs to stream_history

Context

  • Current attribute playback_history doesn't make sense if were using streaming service
  • Only 5 songs are stored in playback history

How to do it

  • Rename property playback_history with stream_history
  • Update references to playback history with new name
  • Increase size of stream history by modifying MAX_NUMBER_PLAYBACK_HISTORY_SONGS
  • For user stream history section in user profile frontend it will be needed to only show 5 songs and add a ShowAllItems new object for showing the rest of the songs. This mini-task can be done by the assignee or @AntonioMrtz if requested

Testing

  • Update test that checks user history

🖐️ Learn how to CONTRIBUTE, all help is welcomed :)

📚 Check out the project documentation for more info

⭐ Help this project grow by giving it a star if you like it!

😵 Trello links are used for traceability, do not ask to join the board before leaving a comment in the related issue
@AntonioMrtz AntonioMrtz added good first issue Good for newcomers backend Backend related issues refactor Code changes or improvements that do not change code behaviour help-wanted Help is wanted python Pull requests that update Python code labels Sep 25, 2024
@AntonioMrtz
Copy link
Owner Author

Expand user playback history to store more songs

@AntonioMrtz AntonioMrtz added the frontend Frontend related issues label Sep 29, 2024
@telepcak
Copy link

Hi @AntonioMrtz , i would like to solve this issue, could you please assign this to me ?

@AntonioMrtz
Copy link
Owner Author

Hi @telepcak , all yours. Let me know if you need anything :) . We have the project docs here, take a look if you need more info about common procedures like setting up the project.

@AntonioMrtz AntonioMrtz mentioned this issue Nov 6, 2024
Closed
@AntonioMrtz AntonioMrtz linked a pull request Nov 6, 2024 that will close this issue
#228: Rename property and increase stream history length issue-number #281
Closed
telepcak pushed a commit to telepcak/SpotifyElectron that referenced this issue Nov 12, 2024
refractor: rename variable, fronend fix to show songs in separate com…
c360e6e 
…ponent, openapi generated | [AntonioMrtz#228]
telepcak pushed a commit to telepcak/SpotifyElectron that referenced this issue Nov 13, 2024
refractor: more variables refractoring | [AntonioMrtz#228]
838362c
telepcak pushed a commit to telepcak/SpotifyElectron that referenced this issue Nov 13, 2024
refractor: variable name refractored | [AntonioMrtz#228]
8215d9d
telepcak pushed a commit to telepcak/SpotifyElectron that referenced this issue Nov 30, 2024
minor changes, resolve comments | [AntonioMrtz#228]
741d1f1
@AntonioMrtz
Copy link
Owner Author

Hi @telepcak are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Backend related issues frontend Frontend related issues good first issue Good for newcomers help-wanted Help is wanted python Pull requests that update Python code refactor Code changes or improvements that do not change code behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#228: Rename property and increase stream history length issue-number telepcak/SpotifyElectron
2 participants
@telepcak @AntonioMrtz