Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: separate_prod_fin_test #1023

Open
heifner opened this issue Nov 12, 2024 · 0 comments
Open

Test failure: separate_prod_fin_test #1023

heifner opened this issue Nov 12, 2024 · 0 comments
Labels
test-instability tag issues for flaky tests, high priority to address triage

Comments

@heifner
Copy link
Member

heifner commented Nov 12, 2024

https://github.com/AntelopeIO/spring/actions/runs/11788970348/job/32837287849

Traceback (most recent call last):
  File "/__w/spring/spring/build/tests/separate_prod_fin_test.py", line 75, in <module>
    qc_ext = block["qc_extension"]
KeyError: 'qc_extension'

Need to update test to check that qc_extension is in the block before trying to access it.

The test does try to look for it in other blocks, but fails to check that it is there before trying to access it.

    while i < 3: # slow ci/cd might not get all votes in time, try a few blocks
        # LIB has advanced, which indicate at least 2 of non-producer finalizers have voted.
        block_num = cluster.getNode(1).getIrreversibleBlockNum()
        block = cluster.getNode(1).getBlock(block_num)
        qc_ext = block["qc_extension"]
        Print(f'{qc_ext}')
        # "11111" is the representation of a bitset showing which finalizers have voted (we have five total finalizers)
        if qc_ext["qc"]["active_policy_sig"]["strong_votes"] == "11111":
            break
        cluster.getNode(1).waitForLibToAdvance()
        i += 1
    assert i < 3, "Not all finalizers voted"
@heifner heifner added the test-instability tag issues for flaky tests, high priority to address label Nov 12, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-instability tag issues for flaky tests, high priority to address triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants