Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors building EVM contract with 4.0 #175

Closed
spoonincode opened this issue May 4, 2023 · 3 comments
Closed

errors building EVM contract with 4.0 #175

spoonincode opened this issue May 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working 👍 lgtm
Milestone

Comments

@spoonincode
Copy link
Member

I can't tell if this is something buggy in cdt or EVM contract. It's at least a regression for a contract that compiles fine in cdt 3.1

https://github.com/eosnetworkfoundation/eos-evm/actions/runs/4878774094/jobs/8704718768

@spoonincode spoonincode changed the title errors building EVM contract with cdt's main errors building EVM contract with 4.0 May 4, 2023
@stephenpdeos stephenpdeos added bug Something isn't working 👍 lgtm and removed triage labels May 9, 2023
@stephenpdeos stephenpdeos added this to the CDT 4.0.0-rc2 milestone May 9, 2023
@stephenpdeos
Copy link
Member

Assumed to potentially be failing due to recent boost changes

@dimas1185
Copy link
Contributor

this is better to fix on evm side:

here is the problem:
evm has

DataStream& operator<<(DataStream& ds, const std::basic_string<uint8_t>& bs)

defined as it wasn't defined in cdt

and datastream was recently enhanced with this one:

datastream<Stream>& operator << ( datastream<Stream>& ds, const std::basic_string<T>& s )

this causes error: use of overloaded operator '<<' is ambiguous.
Solution is to remove aforementioned code from evm_contract.hpp

@dimas1185 dimas1185 assigned spoonincode and unassigned dimas1185 May 10, 2023
@spoonincode
Copy link
Member Author

Thanks for looking in to it; I went ahead and made eosnetworkfoundation/eos-evm-contract#533 to track it over there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
Development

No branches or pull requests

4 participants