Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating xpansion settings or candidate of a variant does not create a command #1478

Open
2 tasks done
MartinBelthle opened this issue Apr 25, 2023 · 3 comments
Open
2 tasks done
Labels
bug Something isn't working variante xpansion

Comments

@MartinBelthle
Copy link
Contributor

MartinBelthle commented Apr 25, 2023

Description

Currently, the app modifies the Xpansion configuration directly when users make modifications to a variant. This can cause issues when the snapshot is destroyed, as any variant modifications will also be lost.

To address this, we suggest using the command-based approach that generates commands to modify the configuration instead of modifying it directly. This would allow users to track all changes made to the variant configuration, and ensure that they are properly saved and recoverable.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create an xpansion study.
  2. Create a variant from your base study
  3. Go to xpansion parameters
  4. Modifiy one random parameter and save the modification.
  5. See that there are no commands in the variant commands list

Actual Behavior

See above

Expected Behavior

When I modify xpansion settings of my variant, I want an associated command to be created.

Possible Solution

The API concerning Xpansion (PUT or POST, candidate or settings) should remain consistent for base studies, but should generate a command if the study is a variant. To update settings, it is recommended to use the commands UpdateConfig or UpdateRawFile. Creating a candidate may be more complex, as the API may also need to create base case settings.

Environment

  • Production
  • Staging
@MartinBelthle MartinBelthle added bug Something isn't working xpansion variante labels Apr 25, 2023
@MartinBelthle
Copy link
Contributor Author

MartinBelthle commented Apr 26, 2023

Creating another Xpansion candidate in a variant does not create a command neither

@MartinBelthle MartinBelthle changed the title Updating xpansion settings of a variant does not create a command Updating xpansion settings or candidate of a variant does not create a command Apr 26, 2023
@laurent-laporte-pro
Copy link
Contributor

Creating another Xpansion candidate in a variant does not create a command neither

What do you mean by “creating a candidate”?

@MartinBelthle MartinBelthle self-assigned this Apr 28, 2023
@MartinBelthle
Copy link
Contributor Author

MartinBelthle commented Apr 28, 2023

In fact, every Xpansion API are only designed to handle raw studies and when applied on variant, they only modify the snapshot whithout creating a command. I started to work on this issue which is not a big concern for now according to Thomas Bittar but could be in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working variante xpansion
Projects
None yet
Development

No branches or pull requests

2 participants