You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the app modifies the Xpansion configuration directly when users make modifications to a variant. This can cause issues when the snapshot is destroyed, as any variant modifications will also be lost.
To address this, we suggest using the command-based approach that generates commands to modify the configuration instead of modifying it directly. This would allow users to track all changes made to the variant configuration, and ensure that they are properly saved and recoverable.
Steps to Reproduce
Steps to reproduce the behavior:
Create an xpansion study.
Create a variant from your base study
Go to xpansion parameters
Modifiy one random parameter and save the modification.
See that there are no commands in the variant commands list
Actual Behavior
See above
Expected Behavior
When I modify xpansion settings of my variant, I want an associated command to be created.
Possible Solution
The API concerning Xpansion (PUT or POST, candidate or settings) should remain consistent for base studies, but should generate a command if the study is a variant. To update settings, it is recommended to use the commands UpdateConfig or UpdateRawFile. Creating a candidate may be more complex, as the API may also need to create base case settings.
Environment
Production
Staging
The text was updated successfully, but these errors were encountered:
Creating another Xpansion candidate in a variant does not create a command neither
MartinBelthle
changed the title
Updating xpansion settings of a variant does not create a command
Updating xpansion settings or candidate of a variant does not create a command
Apr 26, 2023
In fact, every Xpansion API are only designed to handle raw studies and when applied on variant, they only modify the snapshot whithout creating a command. I started to work on this issue which is not a big concern for now according to Thomas Bittar but could be in the future.
Description
Currently, the app modifies the Xpansion configuration directly when users make modifications to a variant. This can cause issues when the snapshot is destroyed, as any variant modifications will also be lost.
To address this, we suggest using the command-based approach that generates commands to modify the configuration instead of modifying it directly. This would allow users to track all changes made to the variant configuration, and ensure that they are properly saved and recoverable.
Steps to Reproduce
Steps to reproduce the behavior:
Actual Behavior
See above
Expected Behavior
When I modify xpansion settings of my variant, I want an associated command to be created.
Possible Solution
The API concerning Xpansion (PUT or POST, candidate or settings) should remain consistent for base studies, but should generate a command if the study is a variant. To update settings, it is recommended to use the commands UpdateConfig or UpdateRawFile. Creating a candidate may be more complex, as the API may also need to create base case settings.
Environment
The text was updated successfully, but these errors were encountered: