-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode stream titles break end marker #26
Comments
Aha, didn't know len() used the amount of bytes as an indicator for length, and as unicode characters can be multiple bytes long. Will submit hotfix for this now. |
I can't seem to replicate it with streams using unicode characters and as i'm currently at work I can't start up a test stream to test specific characters. Could you link any streams that have characters that are breaking the bot? Thanks |
http://www.twitch.tv/yeezuswalks The title that's broken it was |
Thank you. I've been able to recreate the bug with that string and will work on a fix. |
@diceroll123 This should be fixed now, there are still some unicode issues I can foresee (users messaging non-ascii characters to the bot's inbox), but it should no longer have an issue with the stream titles. Will close this issue for now and move to a more generic issue: Please let me know if the issue hasn't been fixed or you encounter any other issues :) |
Unicode characters take up 2 characters in a len() so if there are any in a stream title, this pushes the index of
end
(seeupdate_sidebar
function) to be further.2 unicode characters makes the index 4 characters off, making the sidebar have
[](#endmarker)ker)ker)
(and so on) if it persistsThe text was updated successfully, but these errors were encountered: