Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect need to transpose input #25

Open
ngiangre opened this issue Jan 3, 2021 · 6 comments
Open

detect need to transpose input #25

ngiangre opened this issue Jan 3, 2021 · 6 comments

Comments

@ngiangre
Copy link
Collaborator

ngiangre commented Jan 3, 2021

It should be defined whether input/masks need to be transposed - it shouldn't be left up to the user. It's not intuitive what the transpose flag should be...

@AndrewC160
Copy link
Owner

AndrewC160 commented Jan 21, 2021

Should we just establish "Input metadata tables should be oriented with one patient per column. In the event that a transposed table is to be used, the argument 'transpose_input_table' should be used?"

Otherwise detecting the orientation isn't super obvious...it could be a long format, or it could be a dataset with lots of fields.

@ngiangre
Copy link
Collaborator Author

ngiangre commented Jan 21, 2021 via email

@AndrewC160
Copy link
Owner

I agree, but what would we use to decide the orientation? If the user provides a CSV/TSV without knowable column/row names we'd need to figure out which are sample names and which are metadata values. If the dataset is sufficeintly large we could have a check for length/width, i.e. "Either they collected 30,000 metadata values or this table is long", but that's not a guarantee...especially with test data that we use and that people will probably feed in.

@ngiangre
Copy link
Collaborator Author

ngiangre commented Jan 21, 2021 via email

@AndrewC160
Copy link
Owner

Another option is to have the package figure it out when the user provides a mask ("Does row 1 or column 1 have more of the following aliases?"), but I think that would require a bit of reconfiguring of the work flow.

@ngiangre
Copy link
Collaborator Author

ngiangre commented Jan 21, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants