Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20 support! #87

Open
AomiRaku opened this issue Jun 12, 2023 · 34 comments
Open

1.20 support! #87

AomiRaku opened this issue Jun 12, 2023 · 34 comments

Comments

@AomiRaku
Copy link

very need!!! thannnnnnnnks!

@rakantoh
Copy link

+1, please update to 1.20-1.20.x, this mod is now elemental for me, many thanks

@Pluelagoon
Copy link

hope he does it soon

@lluxia
Copy link

lluxia commented Jul 4, 2023

The main issue with updating this mod to 1.20 is Stacc API. This mod depends on Stacc API to work. Even if we update this mod to 1.20, it won't run because Stacc API would crash the game since it still needs to be updated to 1.20 by its author.

@rakantoh
Copy link

rakantoh commented Jul 6, 2023

The main issue with updating this mod to 1.20 is Stacc API. This mod depends on Stacc API to work. Even if we update this mod to 1.20, it won't run because Stacc API would crash the game since it still needs to be updated to 1.20 by its author.

ok, i understand that depends of the stac api, however, i think that andrew is capable of modify/update stacc api, may be i am wrong, but may be andrew can fork the stacc api project and modify/update it. anyways, i wait for the update of stacker soon.

@topia
Copy link

topia commented Jul 6, 2023

You can also do it yourself if you mention forking/modifying upstream code. Sending the patch (as a pull request) is a good starting point to achieve your goal; This mod is his second mod; please calm down.

@rakantoh
Copy link

rakantoh commented Jul 6, 2023

You can also do it yourself if you mention forking/modifying upstream code. Sending the patch (as a pull request) is a good starting point to achieve your goal; This mod is his second mod; please calm down.

it was only a comment... calm down yourself, andrew are a programmer, and as programmer he can edit the neccesary api, you and me (or at least me) aren't programmers, so i can't edit any mod... please don't be rude, this is only a comment and suggestions space, so please be more respecful... i only post a option or sugerence...

@topia
Copy link

topia commented Jul 7, 2023

I apologize for not understanding your respect for the author in your comment. Now I know that you have a different view of modding/programming than me. Modding new (another) thing requires new knowledge/research; sometimes, they should repeat try-and-failure many times. I prefer to mention contributing (or forking) upstream if they already modified the upstream code or decided to do it.
I think modding is motivated by the hope of improving something. And (learning) programming is also motivated by the same. If you think the mod is elemental, you might have good motivation to start learning programming.

@rakantoh
Copy link

rakantoh commented Jul 7, 2023

I apologize for not understanding your respect for the author in your comment. Now I know that you have a different view of modding/programming than me. Modding new (another) thing requires new knowledge/research; sometimes, they should repeat try-and-failure many times. I prefer to mention contributing (or forking) upstream if they already modified the upstream code or decided to do it. I think modding is motivated by the hope of improving something. And (learning) programming is also motivated by the same. If you think the mod is elemental, you might have good motivation to start learning programming.

Yeah, the mod are elemental for me, as a player/gamer, not as programmer, and yes, i have very respect to andrew and for all good modders that do all types of mods, i know how hard is doing a mod, and for this is my respect to andrew and all modders that do this possible, giving us more fun and new content for the games.

@BaccarWozat
Copy link

BaccarWozat commented Jul 15, 2023

I can play the game without Stacker, but it always entails finding all the inventories with >64 items per stack and moving them into other chests, before updating the version. (It usually takes about 3 hours to move everything.) Fortunately, I have a large base with lots of room for extra items, but this has been happening every new MC version, and that assumes Stacker didn't break during snapshots...
Every time, I keep thinking it will reach the point that Mojang will stop messing with inventory code so Fabric could be made to ignore Stacker's version dependency, but it keeps breaking anyway.
Oh well. Not anyone's fault, and I will await whatever happens.

@rakantoh
Copy link

I can play the game without Stacker, but it always entails finding all the inventories with >64 items per stack and moving them into other chests, before updating the version. (It usually takes about 3 hours to move everything.) Fortunately, I have a large base with lots of room for extra items, but this has been happening every new MC version, and that assumes Stacker didn't break during snapshots... Every time, I keep thinking it will reach the point that Mojang will stop messing with inventory code so Fabric could be made to ignore version dependency, but it keeps breaking anyway. Oh well. Not anyone's fault, and I will await whatever happens.

i prefer to stay in the latest version compatible with stacker and wait for the mod update, precisely for to not move the items between chests, i have a lot of chest and rooms too, but i prefer wait.

@rakantoh
Copy link

I think that stacker will not have more updates, it's sad, anyways thanks to andrew for this great mod, and i want to someone continue to the development of this mod, with the permission and approval of andrew of course.

@AmibeSkyfy16
Copy link

There is a similar mod called stackable127 available on CF and MR
https://www.curseforge.com/minecraft/mc-mods/stackable127

@sandgray
Copy link

The main issue with updating this mod to 1.20 is Stacc API. This mod depends on Stacc API to work. Even if we update this mod to 1.20, it won't run because Stacc API would crash the game since it still needs to be updated to 1.20 by its author.

https://github.com/Noaaan/Stacc/tree/master ???

@rakantoh
Copy link

The main issue with updating this mod to 1.20 is Stacc API. This mod depends on Stacc API to work. Even if we update this mod to 1.20, it won't run because Stacc API would crash the game since it still needs to be updated to 1.20 by its author.

https://github.com/Noaaan/Stacc/tree/master ???

ok, stacc api are updated to 1.20/1.20.x, now wait stacker to be updated too

@FumpleWumper
Copy link

Leaving my comment here as well! I miss this mod everyday when I'm playing in 1.20 and my inventory gets filled up with building materials!

@Rafii2198
Copy link

Rafii2198 commented Oct 19, 2023

I changed the fabric.mod.json to say it needs 1.20.1 and not 1.19.4, I also had Bits And Chisels which implements newer stacc version and the mod works well. There is an issue tho, it's the compatibility with something else, I will try to find which mod is causing it, but basically you can't place more than 64 of item into a slot and throwing away an item stack that has more than 64 items in it make it just disappear, basically only thing that works is giving yourself somehow more than 64 items but then at most you can hold it if you gave it in the hotbar.
Edit: Actually it is not perfect as I mentioned, you can have a stack at most 1024 and not something crazy like 1M.

@rakantoh
Copy link

I changed the fabric.mod.json to say it needs 1.20.1 and not 1.19.4, I also had Bits And Chisels which implements newer stacc version and the mod works well. There is an issue tho, it's the compatibility with something else, I will try to find which mod is causing it, but basically you can't place more than 64 of item into a slot and throwing away an item stack that has more than 64 items in it make it just disappear, basically only thing that works is giving yourself somehow more than 64 items but then at most you can hold it if you gave it in the hotbar. Edit: Actually it is not perfect as I mentioned, you can have a stack at most 1024 and not something crazy like 1M.

maybe as you mentioned, it's an incompability with other mod, however, i do the same thing, in the stacker json i changed the minecraft required version, and change the name of the stacc file (the original stacc api inside stacker is named "stacc-api-1.5.2.jar"), to "stacc-1.5.2.jar", and replace the stacc api original file to the stacc api of the bits and chisels mod, that stacc api have some modification, maybe made by the author of the bits and chisels mod, and at least, in my case i can have a stack of 102k and i can throw the entire stack and get it again, with the same quantity. Anyways, it was a few minutes test, so i will play with that modified stacker and i will comment if any change or possible corrupts/crashes.
It's dissapointed that Andrew this mod it's not important, this is a comment from curse forge made by andrew:
"The popularity of my mods don't matter to me - I've made a couple mods that I've not even released publicly.

I'm currently working on 30+ mods right now (yes really, you can check my GitHub). I am also a student and have other hobbies besides modding Minecraft. Stacker will get updated eventually, but it is not my highest priority right now."

I understand that he have life and other things, but i think that modify or update your own mod is relatively easy, and if the author of bits and chisels can update stacc api, i think that andrew can too.

@Rafii2198
Copy link

The mod that caused my incompatibilities was Inventory Profiles Next. Also, interestingly about Bits And Chisels is that the bits are not even stacking to something more than 64 so the api is not even used unless something just bugged out with Stacker as I didn't test it on its own.

@andw20
Copy link

andw20 commented Oct 20, 2023

Yeah I wish that he would release an actual update to it but it won't happen anytime soon sadly since I read his comment on CurseForge a few months ago. I just forked it and made it work for 1.20.1 with no bugs that I found at least and my friends said they had no problem of it whatsoever. I've been using my version since June 10th. I'm not sure if I am allowed to post my forked version of stacker here since I know that some people have trust issues with unofficial jar files.

EDIT: I also forgot to mention that I also used Inventory Profiles Next mod installed as well and had no issues

@rakantoh
Copy link

Yeah I wish that he would release an actual update to it but it won't happen anytime soon sadly since I read his comment on CurseForge a few months ago. I just forked it and made it work for 1.20.1 with no bugs that I found at least and my friends said they had no problem of it whatsoever. I've been using my version since June 10th. I'm not sure if I am allowed to post my forked version of stacker here since I know that some people have trust issues with unofficial jar files.

EDIT: I also forgot to mention that I also used Inventory Profiles Next mod installed as well and had no issues

I think that you can publish your stacker version, with mention and credits of the original author, andrew, and the changelog/updates that you do to the mod (minor notes, nothing complicated). Are you programmer or similar? i will be happy if you or other person continue the development of stacker.

@Rafii2198
Copy link

PRs also seems to be welcome here too

@andw20
Copy link

andw20 commented Oct 20, 2023

Yeah I was thinking of doing a PR but the issue is, I don't have those files anymore lmao. I only have the .jar file for stacker 1.20.1 and plus I don't remember what I changed since it was months ago. And I probably won't be able to keep updating it everytime since I started working at a hospital little bit after 1.20.1 was released and won't have that much time.

And sorry for self-promoting but I put it in my public modpack on Modrinth and was verified by the moderators if you want it download it and just grab the mod from there since I don't want Andrew to get mad at me for publishing a jar file here. It's available in every 1.20.1 modpack version I have there. Also, I only did Fabric since I don't use Quilt so it may or may not work if you use that. If you don't want to do all of that, you can add me on Discord (username in my bio) and I can send you the jar file there if you wish.

@rakantoh
Copy link

Yeah I was thinking of doing a PR but the issue is, I don't have those files anymore lmao. I only have the .jar file for stacker 1.20.1 and plus I don't remember what I changed since it was months ago. And I probably won't be able to keep updating it everytime since I started working at a hospital little bit after 1.20.1 was released and won't have that much time.

And sorry for self-promoting but I put it in my public modpack on Modrinth and was verified by the moderators if you want it download it and just grab the mod from there since I don't want Andrew to get mad at me for publishing a jar file here. It's available in every 1.20.1 modpack version I have there. Also, I only did Fabric since I don't use Quilt so it may or may not work if you use that. If you don't want to do all of that, you can add me on Discord (username in my bio) and I can send you the jar file there if you wish.

i downloaded the modpack, but i not use curseforge app or a launcher with modpack support, so i will write you in discord, the nick is the same, andw20?

@Rafii2198
Copy link

Rafii2198 commented Oct 22, 2023

i downloaded the modpack, but i not use curseforge app or a launcher with modpack support, so i will write you in discord, the nick is the same, andw20?

You can just open the .mrpack file as a zip file, the mod jar will be in overwrites/mods folder. I am using it and I haven't seen any issues, except that my original issue of items being able to stack up to 1024 in a slot still happens but weird enough only sometimes and restarting the game fixes it. But it seems it is an issue with my modpack, some incompatibility and not the mod itself.

@rakantoh
Copy link

Sadly the stacker version of @andw20 no works on 1.20.2-1.20.4, because code changes made by mojang, so, again we or at least me stucks on 1.20.1....

@yum13241
Copy link

Stacc-API is on 1.20.4 now, lol.

@rakantoh
Copy link

Stacc-API is on 1.20.4 now, lol.

can you share me the link or profile to stacc api? thanks

@rakantoh
Copy link

@yum13241 i already downloaded stacc api 1.8.0, apparently only for 1.20.2, but works in 1.20.4, so, i post stacker with new stacc api, at least for me and for 5 minutes, works perfect.
stacker.zip

@Mortycio
Copy link

So is there or isn’t there a mod for Fabric that increases stack limits? Stacc-api has been updated to 1.20.2! I am playing with 1.20.1.

@rakantoh
Copy link

So is there or isn’t there a mod for Fabric that increases stack limits? Stacc-api has been updated to 1.20.2! I am playing with 1.20.1.

in my last comment:

@yum13241 i already downloaded stacc api 1.8.0, apparently only for 1.20.2, but works in 1.20.4, so, i post stacker with new stacc api, at least for me and for 5 minutes, works perfect. stacker.zip

i made a stacker with staccapi updated, works with no issues in 1.20.2 - 1.20.4 (tested for myself during different game sessions)

@Mortycio
Copy link

So is there or isn’t there a mod for Fabric that increases stack limits? Stacc-api has been updated to 1.20.2! I am playing with 1.20.1.

in my last comment:

@yum13241 i already downloaded stacc api 1.8.0, apparently only for 1.20.2, but works in 1.20.4, so, i post stacker with new stacc api, at least for me and for 5 minutes, works perfect. stacker.zip

i made a stacker with staccapi updated, works with no issues in 1.20.2 - 1.20.4 (tested for myself during different game sessions)

I tried it in 1.20.1 with no other mods but didn't work. I enabled just fabric api, stacc api and cloth config.

@Mortycio
Copy link

So is there or isn’t there a mod for Fabric that increases stack limits? Stacc-api has been updated to 1.20.2! I am playing with 1.20.1.

in my last comment:

@yum13241 i already downloaded stacc api 1.8.0, apparently only for 1.20.2, but works in 1.20.4, so, i post stacker with new stacc api, at least for me and for 5 minutes, works perfect. stacker.zip

i made a stacker with staccapi updated, works with no issues in 1.20.2 - 1.20.4 (tested for myself during different game sessions)

Can you help me sir? Please I need this mod soooo badly I could pay XO

@AverageAnime
Copy link

I uploaded a 1.20.1 version here: https://www.curseforge.com/minecraft/mc-mods/stack-size-edit-fabric

@Mortycio
Copy link

I uploaded a 1.20.1 version here: https://www.curseforge.com/minecraft/mc-mods/stack-size-edit-fabric

You're a hero! Works wonderfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests