Skip to content

Commit 4074f13

Browse files
committed
Fixes with cmake > 3.25
1 parent 9b82f8e commit 4074f13

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

cmake/FindNVTX.cmake

+5-5
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ if(CMAKE_C_COMPILER_ID STREQUAL "PGI" OR CMAKE_C_COMPILER_ID STREQUAL "NVHPC" )
1111
set (DEFAULT_DR_HOOK_NVTX ON)
1212

1313
if( ${CMAKE_VERSION} VERSION_LESS "3.25" )
14-
find_package(CUDAToolkit REQUIRED COMPONENTS CUDA::nvToolsExt)
14+
find_package(CUDAToolkit COMPONENTS CUDA::nvToolsExt)
1515

1616
find_path(NVTX_ROOT
1717
NAMES include/nvToolsExt.h
@@ -37,9 +37,9 @@ if(CMAKE_C_COMPILER_ID STREQUAL "PGI" OR CMAKE_C_COMPILER_ID STREQUAL "NVHPC" )
3737
mark_as_advanced(
3838
NVTX_LIBRARIES
3939
NVTX_INCLUDE_DIRS
40-
)
40+
)
4141
else()
42-
find_package(CUDAToolkit REQUIRED COMPONENTS CUDA::nvtx3)
42+
find_package(CUDAToolkit COMPONENTS CUDA::nvtx3)
4343

4444
find_path(NVTX_ROOT
4545
NAMES include/nvtx3/nvToolsExt.h
@@ -58,10 +58,10 @@ if(CMAKE_C_COMPILER_ID STREQUAL "PGI" OR CMAKE_C_COMPILER_ID STREQUAL "NVHPC" )
5858

5959
mark_as_advanced(
6060
NVTX_INCLUDE_DIRS
61-
)
61+
)
6262
endif()
6363

6464

6565
else ()
6666
set (DEFAULT_DR_HOOK_NVTX OFF)
67-
endif ()
67+
endif ()

src/fiat/CMakeLists.txt

+4-1
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,12 @@ if (HAVE_DR_HOOK_NVTX)
7676
target_include_directories(fiat PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/drhook/extensions/nvtx)
7777

7878
# Files defined externally
79-
target_link_libraries ( fiat PRIVATE ${NVTX_LIBRARIES} )
8079
target_include_directories( fiat PRIVATE ${NVTX_INCLUDE_DIRS} )
8180
target_compile_definitions( fiat PRIVATE DR_HOOK_HAVE_NVTX=1 )
81+
if( CMAKE_VERSION VERSION_LESS 3.25 )
82+
target_link_libraries ( fiat PRIVATE ${NVTX_LIBRARIES} )
83+
target_compile_definitions( fiat PRIVATE DR_HOOK_NVTX_LEGACY )
84+
endif()
8285
endif()
8386

8487
if( ${CMAKE_SYSTEM_NAME} MATCHES "Darwin" )

src/fiat/drhook/extensions/nvtx/dr_hook_nvtx.c

+4-1
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@
99
* nor does it submit to any jurisdiction.
1010
*/
1111

12+
#ifdef DR_HOOK_NVTX_LEGACY
1213
#include <nvToolsExt.h>
13-
//#include <nvtx3/nvToolsExt.h>
14+
#else
15+
#include <nvtx3/nvToolsExt.h>
16+
#endif
1417
#include <string.h>
1518
#include <stdlib.h>
1619

0 commit comments

Comments
 (0)