Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-suite event loop is not used correctly #41

Open
AndrejMitrovic opened this issue Apr 17, 2020 · 0 comments
Open

Test-suite event loop is not used correctly #41

AndrejMitrovic opened this issue Apr 17, 2020 · 0 comments
Labels
type-bug Something isn't working

Comments

@AndrejMitrovic
Copy link
Owner

There is something strange about the way the tests are designed. There's a set of tests which do things like the following:

sendEvent(...);
testEventFired();

sendEvent(...);
testEventFired();

app.testRun()

And inside of testRun the actual event loop is run. But, by the time the thread reaches testRun all of the previous tests will have been ran already. So I'm not sure how these tests even passed.

On Mac OS the event handling tests fail. Maybe on Windows / Linux the event loop is already running in the background. Need to investigate.

@AndrejMitrovic AndrejMitrovic added the type-bug Something isn't working label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant