Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running the pycaw tests modifies the system and breaks audio #31

Open
reversefold opened this issue Feb 8, 2021 · 1 comment
Open

Running the pycaw tests modifies the system and breaks audio #31

reversefold opened this issue Feb 8, 2021 · 1 comment

Comments

@reversefold
Copy link
Contributor

I ran the tests via tox to verify my recent pull request and now my audio is broken. Something was changed and one of my audio devices was no longer working properly. I had to disable it and then re-enable it in the Sound Playback tab for it to work again.

The pycaw tests should not be modifying system they are running on. Any write operations should be mocked out or should be limited to some kind of defined test interface.
@AndreMiras
Copy link
Owner

Agree, we should have all the unit tests mocked and then some specific integration tests (not ran by default) not mocked.
Thanks for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreMiras @reversefold