From 7e1cc6382a1f0a2ca97a6316fda7d5ef544d32a6 Mon Sep 17 00:00:00 2001 From: akarin Date: Tue, 21 Feb 2023 14:23:45 +0900 Subject: [PATCH] Revert "fix build for latest boost, skip test on windows" This reverts commit 49e383f5243c30d3cdaaea8911b487844b9fcd50. Signed-off-by: akarin --- .github/workflows/gha-ci.yml | 4 +--- libaegisub/include/libaegisub/lua/utils.h | 7 ------- src/auto4_lua.cpp | 2 +- src/command/video.cpp | 2 +- src/dialog_attachments.cpp | 2 +- 5 files changed, 4 insertions(+), 13 deletions(-) diff --git a/.github/workflows/gha-ci.yml b/.github/workflows/gha-ci.yml index 0cf1e405d7..31cfa50994 100644 --- a/.github/workflows/gha-ci.yml +++ b/.github/workflows/gha-ci.yml @@ -2,7 +2,7 @@ name: GitHubActions CI tests on: push: - branches: [master, dev, ci, mod] + branches: [master, dev, ci] # pull_request: workflow_dispatch: @@ -180,8 +180,6 @@ jobs: MSBuild.exe Aegisub.vcxproj -p:Configuration=Release - name: run tests - # latest boost broke the build for tests/vfr.cpp. - if: false run: | Set-Location build-dir MSBuild.exe test.vcxproj -p:Configuration=Release diff --git a/libaegisub/include/libaegisub/lua/utils.h b/libaegisub/include/libaegisub/lua/utils.h index 081c16243a..c5a65d6e44 100644 --- a/libaegisub/include/libaegisub/lua/utils.h +++ b/libaegisub/include/libaegisub/lua/utils.h @@ -22,7 +22,6 @@ #include #include -#include #ifndef BOOST_NORETURN #include @@ -78,12 +77,6 @@ void push_value(lua_State *L, std::vector const& value) { } } -template -inline void push_value(lua_State *L, boost::flyweight const& value) { - const T& v = value; - push_value(L, v); -} - int exception_wrapper(lua_State *L, int (*func)(lua_State *L)); /// Wrap a function which may throw exceptions and make it trigger lua errors /// whenever it throws diff --git a/src/auto4_lua.cpp b/src/auto4_lua.cpp index 162eb8bc56..6c131902ec 100644 --- a/src/auto4_lua.cpp +++ b/src/auto4_lua.cpp @@ -119,7 +119,7 @@ namespace { int get_translation(lua_State *L) { wxString str(check_wxstring(L, 1)); - push_value(L, (const char *)_(str).utf8_str()); + push_value(L, _(str).utf8_str()); return 1; } diff --git a/src/command/video.cpp b/src/command/video.cpp index c0499a38cd..d3ffaf7fe0 100644 --- a/src/command/video.cpp +++ b/src/command/video.cpp @@ -475,7 +475,7 @@ static void save_snapshot(agi::Context *c, bool raw) { // If where ever that is isn't defined, we can't save there if ((basepath == "\\") || (basepath == "/")) { // So save to the current user's home dir instead - basepath = (const char*)wxGetHomeDir().c_str(); + basepath = wxGetHomeDir().c_str(); } } // Actual fixed (possibly relative) path, decode it diff --git a/src/dialog_attachments.cpp b/src/dialog_attachments.cpp index e758012d4d..38ff530278 100644 --- a/src/dialog_attachments.cpp +++ b/src/dialog_attachments.cpp @@ -161,7 +161,7 @@ void DialogAttachments::OnExtract(wxCommandEvent &) { // Multiple or single? if (listView->GetNextSelected(i) != -1) - path = (const char*)wxDirSelector(_("Select the path to save the files to:"), to_wx(OPT_GET("Path/Fonts Collector Destination")->GetString())).c_str(); + path = wxDirSelector(_("Select the path to save the files to:"), to_wx(OPT_GET("Path/Fonts Collector Destination")->GetString())).c_str(); else { path = SaveFileSelector( _("Select the path to save the file to:"),