Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Handling in base_save_state_folder #14

Open
silverhadch opened this issue Oct 22, 2024 · 0 comments
Open

Error Handling in base_save_state_folder #14

silverhadch opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@silverhadch
Copy link
Contributor

The fs::create_dir_all(&base_saved_states_dir).ok()?; silently ignores errors when creating directories. If there is an issue with permissions or file system access, it will fail without notifying the user.

Use proper error handling (e.g., expect or Result) to provide more informative feedback.
@Amjad50 Amjad50 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amjad50 @silverhadch