Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is not hexagonal architecture #2

Open
MyEidos opened this issue Oct 3, 2021 · 1 comment
Open

This is not hexagonal architecture #2

MyEidos opened this issue Oct 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@MyEidos
Copy link

MyEidos commented Oct 3, 2021

The current project doesn't satisfy the requirements of hexagonal architecture.
Ex: concrete (!) EF DB context (!) is used on the domain layer:
public DealDomain(ApplicationDbContext dbContext)

Which creates strong coupling with DB layer.

@MyEidos MyEidos added the enhancement New feature or request label Oct 3, 2021
@Innokmm
Copy link

Innokmm commented Dec 8, 2021

I agree, the first thing I've noticed in the Domain layer is a reference to Persistence, which as per comment from MyEidos ends up as dependency to the EF:

image

Shouldn't Persistence depend on Domain layer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants