Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fisher's Randomization Test yields nondeterministic results #70

Open
marianrh opened this issue Nov 21, 2024 · 0 comments
Open

Fisher's Randomization Test yields nondeterministic results #70

marianrh opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@marianrh
Copy link

Describe the bug
When running Fisher's Randomization Test multiple times using the same data and same parameters, the significance results vary between runs. This happens even when the random seed is fixed and also when just a single thread is used.

To Reproduce
Run ranx.compare(qrels, runs, metrics=["precision@1", "recall@20"], stat_test="fisher", max_p=0.05, n_permutations=1000, make_comparable=True, threads=1, random_seed=0).
qrels has a few thousand entries, each element in runs about a thousand entries.

When running compare() multiple times, the significance assessments are slightly different between runs. On my data, this can be observed after three to five compare() runs.

Expected behavior
I expect multiple compare() runs on the same data and with the same parameters to always show the exact same significance results.

@marianrh marianrh added the bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant