Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Generating an app/lib with a scope leads to unexpected behaviour #2627

Open
malek-benazzouz opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working priority:medium

Comments

@malek-benazzouz
Copy link

malek-benazzouz commented Dec 18, 2024

Package name

core

Package version

11.5.3

Reproduction steps

Create a project with @o3r/create, then generate an app and a lib with a scope:

npm create @o3r project
ng g application @scope/app
ng g library @scope/lib

Current result

  1. My app is created under folder apps/scope-app.
  2. My lib is created under folder libs/scope-lib.
  3. The following error is raised during the ng g library @scope/lib step:
No application detected, the Otter environment will not be setup
No application detected, the environment can not be generated

This error is not raised if I run the same scenario but without giving a scope (e.g., if I run ng g application app).

Expected result

  1. My app should be created under folder apps/app.
  2. My lib should be created under folder libs/lib.
  3. No error during the ng generate steps.

Additional comments

I specified that the impacted package is core because that is where the error logging is done, but the issue root cause may be in an other package.

@malek-benazzouz malek-benazzouz added bug Something isn't working triage labels Dec 18, 2024
@kpanot kpanot added this to the On boarding improvement milestone Dec 19, 2024
@kpanot
Copy link
Contributor

kpanot commented Dec 19, 2024

Hi,

Thank you for the report.
I do not know if we want to remove the scope from the generated path. If do so, we won't be able to generate 2 packages with the same name but different scope.

@kpanot
Copy link
Contributor

kpanot commented Dec 19, 2024

This issue will lead to the following:

  • Discussion regarding the folder to generate when a scope is specified
  • Bug fix of the generators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants