Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter event banner issue? (Possibly nonissue) #16

Open
biggestsonicfan opened this issue Oct 17, 2022 · 1 comment
Open

Twitter event banner issue? (Possibly nonissue) #16

biggestsonicfan opened this issue Oct 17, 2022 · 1 comment

Comments

@biggestsonicfan
Copy link

So I ran into a weird situation where if the tweet is a link to a twitter event, the file downloads as {author[name]}—{(this)date:%Y.%m.%d}—{(this)tweet_id}—{filename}, but if the banner itself is a tweet within the event, it downloads as {author[name]}—{(actual)date:%Y.%m.%d}—{(actual)tweet_id}—{filename}.

Not really sure there's a workaround of this one though, but thought I would bring it some attention.

@AlttiRi
Copy link
Owner

AlttiRi commented Oct 17, 2022

It takes the time from the last-modified HTTP header of the downloaded image, not from the tweet's post time.
#5 (comment)

Hm, never seen such tweets.
https://twitter.com/murgoten/status/1576594857346273280

I'm not sure how exactly it should work the best way.
However, both tweets contain the same image, so they share the same download history entry, while these tweets produce different filenames. Okay, I will check it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants