Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render signe state for signee list summary, await fetching queries before #readyforprint #2939

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

HauklandJ
Copy link
Contributor

Description

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@HauklandJ HauklandJ added the kind/product-feature Pull requests containing new features label Jan 22, 2025
@HauklandJ
Copy link
Contributor Author

/publish

Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.370.signing-summary-polish.5e6a98c8/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.370.signing-summary-polish.5e6a98c8/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

@HauklandJ
Copy link
Contributor Author

/publish

Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.373.signing-summary-polish.81df4ea4/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.373.signing-summary-polish.81df4ea4/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
34.1% Coverage on New Code (required ≥ 45%)
12.0% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@HauklandJ HauklandJ changed the title useEffect instead of useQuery Render signe state for signee list summary, await fetching queries before #readyforprint Jan 24, 2025
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@HauklandJ HauklandJ marked this pull request as ready for review January 24, 2025 13:40
@HauklandJ
Copy link
Contributor Author

/publish

Copy link
Contributor

github-actions bot commented Jan 27, 2025

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.402.signing-summary-polish.aa996b5c/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.402.signing-summary-polish.aa996b5c/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

@HauklandJ HauklandJ linked an issue Jan 27, 2025 that may be closed by this pull request
@HauklandJ HauklandJ merged commit af46555 into feature/signing Jan 30, 2025
21 of 23 checks passed
@HauklandJ HauklandJ deleted the feature/signing-summary-polish branch January 30, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wait for fetching tanstack queries before rendering pdf
2 participants