Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing backend validation #2930

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Jan 21, 2025

Description

Runs backend validation for signing state when signee list has changed.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added the kind/product-feature Pull requests containing new features label Jan 21, 2025
@cammiida cammiida self-assigned this Jan 21, 2025
@cammiida
Copy link
Contributor Author

/publish

Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.348.signing-validation.231d074b/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.1-pr.348.signing-validation.231d074b/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

@cammiida cammiida force-pushed the feature/signing-validation branch from 231d074 to 6f97a23 Compare January 21, 2025 13:39
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.6% Coverage on New Code (required ≥ 45%)
0.0% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@HauklandJ HauklandJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cammiida cammiida merged commit be1a3cb into feature/signing Jan 21, 2025
13 of 15 checks passed
@cammiida cammiida deleted the feature/signing-validation branch January 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants