Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact summary for Grid component #1265

Closed
Tracked by #1502 ...
olemartinorg opened this issue Jun 20, 2023 · 4 comments
Closed
Tracked by #1502 ...

Compact summary for Grid component #1265

olemartinorg opened this issue Jun 20, 2023 · 4 comments
Assignees
Labels
area/summary related to summaries/read-only data representation kind/feature-request New feature or request org/dibk org/krt org/ssb Issues relevant for Statistisk sentralbyrå. status/triage ux Needs some love from a UX resource

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Jun 20, 2023

Description

Update 05.08.24
We believe this issue is sufficiently solved with the new designs and concept for Summary 2.0. I have shown examples from the new grid summary to the original reporter and we could agree that the current design works much better. I'm closing this issue as we don't see a current need for a compact grid component in summary.

Currently only groups (i.e. non-repeating groups) show a compact summary by default. This should be possible for Grid as well, possibly if the Grid component is displayed within a (non-repeating) Group.

Additional Information

Tasks

Preview Give feedback
No tasks being tracked yet.
@olemartinorg olemartinorg added kind/feature-request New feature or request org/ssb Issues relevant for Statistisk sentralbyrå. labels Jun 20, 2023
@RonnyB71 RonnyB71 added ux Needs some love from a UX resource area/summary related to summaries/read-only data representation status/triage labels Jan 31, 2024
@RonnyB71 RonnyB71 moved this to Backlog in Issues SSB Feb 28, 2024
@CelineTrammi
Copy link

Can org/krt be added as a label to this issue as well? 🙏

@Magnusrm Magnusrm moved this to 👷 In Progress in Team Apps Jul 1, 2024
@Magnusrm Magnusrm assigned benjamindehli and unassigned Edavda and benjamindehli Jul 1, 2024
@Magnusrm Magnusrm removed the status in Team Apps Jul 3, 2024
@adamhaeger adamhaeger self-assigned this Jul 29, 2024
@adamhaeger adamhaeger moved this from Backlog to In Progress in Issues SSB Jul 30, 2024
@adamhaeger adamhaeger moved this to 📈 Todo in Team Apps Jul 30, 2024
@adamhaeger
Copy link
Contributor

I've implemented support for compact grid view in this draft PR: #2250

However I cant seem to find design for how the grid summary should look in compact mode, si assigning this to @Edavda for now :)

@adamhaeger adamhaeger assigned Edavda and unassigned adamhaeger Jul 30, 2024
@olemartinorg
Copy link
Contributor Author

I'm not quite sure this is relevant for Summary2? The issue was rooted in old Summary component concepts, and I'd rather wait until we see a need for a more compact variant (or even a less compact variant?) of the Grid component in Summary2 when those experiences start coming in. I'm in favor of just closing this issue as no longer relevant.

@Edavda
Copy link

Edavda commented Aug 5, 2024

I agree with that approach @olemartinorg.
Also, I don't quite understand what the specific needs are here. I looked into the Slack thread that is linked, but I still can't understand exactly what the problem is. We should define that clearly before we design an alternate view for the grid component.

We have a chat scheduled later today around open summary tasks, so we'll look into this issue and figure out how to move forward.

@Edavda Edavda closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues SSB Aug 5, 2024
@Edavda Edavda moved this from 📈 Todo to ✅ Done in Team Apps Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/summary related to summaries/read-only data representation kind/feature-request New feature or request org/dibk org/krt org/ssb Issues relevant for Statistisk sentralbyrå. status/triage ux Needs some love from a UX resource
Projects
Archived in project
Archived in project
Development

No branches or pull requests

6 participants