Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated NullBooleanField #350

Open
kannanvm opened this issue Apr 20, 2023 · 0 comments
Open

Remove deprecated NullBooleanField #350

kannanvm opened this issue Apr 20, 2023 · 0 comments

Comments

@kannanvm
Copy link

NullBooleanField has been deprecated in DRF 3.14. dynamic_rest/filters.py is still using it, giving following error.
ImportError: cannot import name 'NullBooleanField' from 'rest_framework.fields'
kannanvm added a commit to kannanvm/dynamic-rest that referenced this issue Apr 20, 2023
@kannanvm
fix: remove deprecated NullBooleanField
d6e38ee 
`NullBooleanField` was used in `dynamic_rest/fields.py`, to `Convert filter values to booleans for boolean fields` - AltSchool#124. It should not break anything else.
`NullBooleanField` is deprecated on DRF 3.14 - encode/django-rest-framework@d6b87b0. 

Related issue: AltSchool#350
@kannanvm kannanvm mentioned this issue Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kannanvm