Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No improvement with true recombination rate #174

Open
XingerTang opened this issue Sep 3, 2024 · 1 comment
Open

No improvement with true recombination rate #174

XingerTang opened this issue Sep 3, 2024 · 1 comment

Comments

@XingerTang
Copy link
Contributor

@gregorgorjanc @AprilYUZhang
I tried to use the true recombination rate to generate the transmission function of the second Baum-Welch implementation in the peeling cycle, and it turned out no improvement in the accuracy compared to the previous equal recombination rate across all loci transmission rate.
This is weird, I suspect there is something off with the second Baum-Welch implementation, yet by removing the second Baum-Welch implementation, then all of the accuracies dropped significantly.

@XingerTang
Copy link
Contributor Author

XingerTang commented Oct 9, 2024

@AprilYUZhang Please find recombination rate from Martin Johnson's paper and let's resimulate the data with that recombination rate and compare using naive uniform rec rate in AlphaPeel with the realised recombination rate.
If the accuracy is the same under that setting, then there is no point to use improved recombination rate in the peeling program. But we are still interested in using rec input from user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant