Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove trades from mod supplementaries #12

Open
LTCatt opened this issue Apr 25, 2024 · 3 comments
Open

Unable to remove trades from mod supplementaries #12

LTCatt opened this issue Apr 25, 2024 · 3 comments

Comments

@LTCatt
Copy link

LTCatt commented Apr 25, 2024

Minecraft Version

1.20.1

Mod Version

0.9.0

Describe the bug!

I modified wanderer trades using the following code, but the supplementaries injected trades still comes up in morejs 0.9.0.

MoreJSEvents.wandererTrades(event => {
    event.removeVanillaTrades(1);
    event.removeVanillaTrades(2);
    event.removeModdedTrades(1);
    event.removeModdedTrades(2);
    event.addTrade(1, ['3x kubejs:ruby'], '6x minecraft:emerald').maxUses(3);
    event.addTrade(1, ['3x kubejs:amethyst'], '6x kubejs:ruby').maxUses(3);
    event.addTrade(2, ['6x minecraft:emerald'], '2x kubejs:ruby').maxUses(3);
    event.addTrade(2, ['6x kubejs:ruby'], '2x kubejs:amethyst').maxUses(3);
});

image

Crash Report

No response

Log

No response

Additions and Modifications

No

Additions and Modifications Description

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

@LLytho
Copy link
Member

LLytho commented Apr 25, 2024

Hey,
when installing supplementaries, there are no extra trades for me with the wanderer. Do I miss something?

@LTCatt
Copy link
Author

LTCatt commented Apr 25, 2024

I looked into it a bit more. Must execute /reload first, then summon a wandering trader. I don't know why :/

@LLytho
Copy link
Member

LLytho commented Apr 26, 2024

Interesting, will try it. Probably a load order issue. Need to check how easy I can fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants