Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alluxio client as context manager that closes session. #18

Open
peterroelants opened this issue Feb 18, 2021 · 1 comment
Open

Alluxio client as context manager that closes session. #18

peterroelants opened this issue Feb 18, 2021 · 1 comment

Comments

@peterroelants
Copy link

Ideally, shouldn't the Alluxio Client be used as a context manager that opens the requests.Session() as a context manager and closes this session properly (closing all the connection adapters) when the Client exits?

Currently the session object is kept open.
@peterroelants
Copy link
Author

I'm happy to create and submit a PR if this would indeed be better practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterroelants