Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMALLFIX]Change mJournal of AbstractMaster.java and mark as final #15247

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

Sucran
Copy link
Contributor

@Sucran Sucran commented Apr 1, 2022

mark mJournal final

What changes are proposed in this pull request?

fix Alluxio/Community#628

Change mJournal of AbstractMaster.java and mark as final

Why are the changes needed? I assume that mJournal is created for once and use everywhere, it can not be edited or changed unexpectedly.

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes? no

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

Copy link
Contributor

@HelloHorizon HelloHorizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Sucran for your contribution! LGTM.

@HelloHorizon
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 3fe6b7a into Alluxio:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark field mJournal final in core/server/common/src/main/java/alluxio/master/AbstractMaster.java
4 participants