Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mark field as final in AbstractMaster.java #14995

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fix Mark field as final in AbstractMaster.java #14995

merged 1 commit into from
Feb 11, 2022

Conversation

PhVHoang
Copy link
Contributor

What changes are proposed in this pull request?

Mark filed mExecutorServiceFactory in AbstractMaster.java as final

Close Alluxio/Community#627

@PhVHoang
Mark field mExecutorServiceFactory final in core/server/common/src/ma…
768d3e9 
…in/java/alluxio/master/AbstractMaster.java

Signed-off-by: ts-hoangpham <[email protected]>
@alluxio-bot
Copy link
Contributor

Hi @PhVHoang, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@alluxio-bot
Copy link
Contributor

You did it @PhVHoang!

Thank you for signing the Contribution License Agreement.

@apc999
Copy link
Contributor

apc999 commented Feb 11, 2022 

Error: 9.971 [ERROR] alluxio.client.fs.concurrent.ConcurrentFileInStreamIntegrationTest.FileInStreamConcurrency  Time elapsed: 27.099 s  <<< FAILURE!
java.lang.AssertionError: Failed with exception(s) [java.lang.RuntimeException: java.io.IOException: Failed to connect to remote block worker: GrpcServerAddress{HostName=b23dbeaebaf8, SocketAddress=b23dbeaebaf8/172.17.0.2:44305}]
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at alluxio.test.util.ConcurrencyUtils.assertConcurrent(ConcurrencyUtils.java:72)
	at alluxio.client.fs.concurrent.ConcurrentFileInStreamIntegrationTest.FileInStreamConcurrency(ConcurrentFileInStreamIntegrationTest.java:69)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)

@apc999
Copy link
Contributor

apc999 commented Feb 11, 2022

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 93e5d0c into Alluxio:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apc999 apc999 apc999 approved these changes

Assignees

@ggezer ggezer

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@PhVHoang @alluxio-bot @apc999 @ggezer