Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging message template in RocksStore #615

Closed
dbw9580 opened this issue Dec 3, 2021 · 1 comment · Fixed by Alluxio/alluxio#14621
Closed

Fix logging message template in RocksStore #615

dbw9580 opened this issue Dec 3, 2021 · 1 comment · Fixed by Alluxio/alluxio#14621
Labels
Beginner help wanted

Comments

@dbw9580
Copy link

dbw9580 commented Dec 3, 2021

https://github.com/Alluxio/alluxio/blob/99942ae847738c8ac4a2bace2228e4c117b5314c/core/server/master/src/main/java/alluxio/master/metastore/rocks/RocksStore.java#L105
https://github.com/Alluxio/alluxio/blob/99942ae847738c8ac4a2bace2228e4c117b5314c/core/server/master/src/main/java/alluxio/master/metastore/rocks/RocksStore.java#L221

The logging message template should use {} as a placeholder instead of %s.

Change

LOG.info("Closed store at %s", mDbPath);

to

LOG.info("Closed store at {}", mDbPath);
@dbw9580
Copy link
Author

dbw9580 commented Dec 3, 2021 •
edited
Loading

@LuQQiu Please add labels for this task. It's new contributor level.

@rongrong rongrong mentioned this issue Dec 3, 2021
Merged
alluxio-bot pushed a commit to Alluxio/alluxio that referenced this issue Dec 8, 2021
Fix logging message template in RocksStore
46116a7 
### What changes are proposed in this pull request?

Fix logging message template in RocksStore
Fixes Alluxio/Community#615

pr-link: #14621
change-id: cid-f1429eb8f00d3c3f1b67e556f40e08f1f98ebc70
@LuQQiu LuQQiu closed this as completed Dec 8, 2021
yyongycy pushed a commit to yyongycy/alluxio that referenced this issue Jan 6, 2022
@yyongycy
Fix logging message template in RocksStore
e67deac 
### What changes are proposed in this pull request?

Fix logging message template in RocksStore
Fixes Alluxio/Community#615

pr-link: Alluxio#14621
change-id: cid-f1429eb8f00d3c3f1b67e556f40e08f1f98ebc70
Xenorith pushed a commit to Alluxio/alluxio that referenced this issue Feb 7, 2022
@Xenorith
Fix logging message template in RocksStore
1200372 
### What changes are proposed in this pull request?

Fix logging message template in RocksStore
Fixes Alluxio/Community#615

pr-link: #14621
change-id: cid-f1429eb8f00d3c3f1b67e556f40e08f1f98ebc70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logging message template in RocksStore rongrong/alluxio
2 participants
@dbw9580 @LuQQiu