Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMALLFIX] Remove alluxio.user.hostname from REMOVED_KEYS #14460

Merged
merged 1 commit into from
Dec 8, 2021
Merged

[SMALLFIX] Remove alluxio.user.hostname from REMOVED_KEYS #14460

merged 1 commit into from
Dec 8, 2021

Conversation

Xaprice
Copy link
Contributor

@Xaprice Xaprice commented Nov 7, 2021

Fix Alluxio/Community#610

alluxio.user.hostname is not deprecated and is still used.
So remove it from REMOVED_KEYS of alluxio.conf.RemovedKey.

@alluxio-bot
Copy link
Contributor

Hi @Xaprice, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@alluxio-bot
Copy link
Contributor

You did it @Xaprice!

Thank you for signing the Contribution License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021 •
edited
Loading

Codecov Report

Merging #14460 (163d562) into master (8723459) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #14460      +/-   ##
============================================
+ Coverage     41.84%   41.92%   +0.07%     
- Complexity     9321     9342      +21     
============================================
  Files          1495     1495              
  Lines         87509    87507       -2     
  Branches      10428    10428              
============================================
+ Hits          36622    36686      +64     
+ Misses        47905    47842      -63     
+ Partials       2982     2979       -3
Impacted Files Coverage Δ
.../common/src/main/java/alluxio/conf/RemovedKey.java 97.63% <ø> (-0.04%) ⬇️
...rity/authentication/AuthenticatedUserInjector.java 46.51% <0.00%> (-20.94%) ⬇️
...ava/alluxio/master/journal/AsyncJournalWriter.java 83.20% <0.00%> (-0.80%) ⬇️
...io/master/metastore/caching/CachingInodeStore.java 74.05% <0.00%> (-0.30%) ⬇️
...luxio/master/journal/raft/JournalStateMachine.java 39.75% <0.00%> (+0.30%) ⬆️
...alluxio/master/journal/raft/RaftJournalSystem.java 55.25% <0.00%> (+0.38%) ⬆️
...aster/journal/raft/SnapshotReplicationManager.java 63.56% <0.00%> (+1.16%) ⬆️
.../java/alluxio/master/meta/DailyMetadataBackup.java 66.66% <0.00%> (+1.23%) ⬆️
...e/common/src/main/java/alluxio/grpc/GrpcUtils.java 64.52% <0.00%> (+1.50%) ⬆️
...c/main/java/alluxio/proxy/AlluxioProxyProcess.java 65.11% <0.00%> (+2.32%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8723459...163d562. Read the comment docs.

@Xaprice
Copy link
Contributor Author

Xaprice commented Nov 25, 2021

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

Merge unsuccessful: Insufficient permissions to trigger a PR merge. user: Xaprice

@Xaprice
Copy link
Contributor Author

Xaprice commented Nov 25, 2021

@apc999
New contributor's task..
I don't have permission to trigger a PR merge.
Please have a look :-)

@LuQQiu
Copy link
Contributor

LuQQiu commented Dec 8, 2021

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 992699b into Alluxio:master Dec 8, 2021
yyongycy pushed a commit to yyongycy/alluxio that referenced this pull request Jan 6, 2022
@Xaprice @yyongycy
[SMALLFIX] Remove alluxio.user.hostname from REMOVED_KEYS
7869c48 
Fix Alluxio/Community#610

alluxio.user.hostname is not deprecated and is still used.
So remove it from REMOVED_KEYS of alluxio.conf.RemovedKey.

pr-link: Alluxio#14460
change-id: cid-fd7c84df73a84cba5376d25a65c2e6ee97781753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apc999 apc999 apc999 approved these changes

Assignees

@ggezer ggezer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove alluxio.user.hostname from alluxio/conf/RemovedKey.java
6 participants
@Xaprice @alluxio-bot @codecov-commenter @LuQQiu @apc999 @ggezer