Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in MetaMasterConfigurationServiceHandler #13737

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

ns7381
Copy link
Contributor

@ns7381 ns7381 commented Jul 3, 2021

Fixes Alluxio/Community#605

In

}, "getConfiguration", "resquest=%s", responseObserver, options);

Correct the spell of resquest to be request

@alluxio-bot
Copy link
Contributor

Hi @ns7381, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@ns7381 ns7381 changed the title Fix typo in MetaMasterConfigurationServiceHandler #605 Fix typo in MetaMasterConfigurationServiceHandler Jul 3, 2021
@alluxio-bot
Copy link
Contributor

You did it @ns7381!

Thank you for signing the Contribution License Agreement.

Copy link
Contributor

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. it LGTM. @apc999 Please take another look.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #13737 (8c97021) into master (3ec7ef9) will decrease coverage by 9.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13737      +/-   ##
============================================
- Coverage     43.72%   34.64%   -9.08%     
+ Complexity     9074     6960    -2114     
============================================
  Files          1384     1384              
  Lines         80313    80313              
  Branches       9768     9768              
============================================
- Hits          35114    27827    -7287     
- Misses        42269    50091    +7822     
+ Partials       2930     2395     -535     
Impacted Files Coverage Δ
...er/meta/MetaMasterConfigurationServiceHandler.java 46.29% <ø> (ø)
.../main/java/alluxio/master/file/meta/InodeView.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/alluxio/master/metastore/BlockStore.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/alluxio/master/table/CatalogProperty.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/alluxio/master/table/PartitionScheme.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/alluxio/master/AbstractPrimarySelector.java 0.00% <0.00%> (-100.00%) ⬇️
...java/alluxio/master/journal/raft/OnceSupplier.java 0.00% <0.00%> (-100.00%) ⬇️
...java/alluxio/master/file/BlockDeletionContext.java 0.00% <0.00%> (-100.00%) ⬇️
.../alluxio/master/file/meta/LockedInodePathList.java 0.00% <0.00%> (-100.00%) ⬇️
...a/alluxio/master/table/PartitionedTableScheme.java 0.00% <0.00%> (-100.00%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec7ef9...8c97021. Read the comment docs.

@LuQQiu
Copy link
Contributor

LuQQiu commented Jul 8, 2021

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 6f08201 into Alluxio:master Jul 8, 2021
@LuQQiu
Copy link
Contributor

LuQQiu commented Jul 8, 2021

Thanks @ns7381 for fixing the typo!

bzheng888 pushed a commit to bzheng888/alluxio that referenced this pull request Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo in MetaMasterConfigurationServiceHandler
6 participants