-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash when trying to open large images #9
Comments
Thanks to do the test, let me see what i can do |
I limited the maximum image size to 16384x16384 for now, in the mean time I'll still try to find out a way to load huge image |
Awesome, thanks!
If you would manage to pull that off, you'd definitely be one of the first if not the first! Sure, there are always limits, but they can definitely be stretched :D. For codevis the key was to use memory maps, which allowed to handle projects that want to be 80 thousand pixels across, like It's interesting to see how no app I tried was able to decently handle these pictures, not even the ones I'd expect to be very well tested like |
@Byron Thanks for the hints. ChatGPT suggests almost the same, memmap, multi-thread reading, multi-thread generating thumbnails, it's very interesting and challenging, :P |
I am working on a similar image viewer, and I've cheated by resizing larger images into a texture of supported max dimensions and showing a warning. That way users can at least see the image - maybe that could be a temporary workaround? Great work by the way! |
Thanks for sharing, @woelper, and thanks for sharing Somehow I thought that |
Thanks! |
Yes, this should be the image I used: And thanks for the fixes, too! |
Thanks for linking the image! |
Thanks for looking into this :)! I tried the linked app and it's the same. To better illustrate what I mean, please find attached a video. Screen.Recording.2023-07-04.at.10.22.18.mov |
Thanks. wow, that's really odd. I sadly could not reproduce this neither on an Intel nor m2 Mac. I wonder what is causing this, maybe |
I think I figured it out! Screen.Recording.2023-07-04.at.10.36.58.movIndeed, it might be something related to window handling, maybe By the way, I wouldn't mind moving this conversation elsewhere as it is quite off-topic now 😅. |
Thanks for making this tool!
While checking if this could be an image viewer that can handle ridiculous image sizes, I encountered a crash.
Observation
When opening an image with dimensions larger than 16384 pixels, it crashes with:
Expectation
It knows its limits and communicates the issue without crashing.
Reproduction
This is the image I tried to open the full-size version of
(https://github.com/Byron/gitoxide/releases/download/v0.16.0/git-100k-scloc.png)
The text was updated successfully, but these errors were encountered: