Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrainingView.showResult refactor #521

Open
hughes036 opened this issue Oct 1, 2024 · 0 comments
Open

TrainingView.showResult refactor #521

hughes036 opened this issue Oct 1, 2024 · 0 comments
Labels

Comments

@hughes036
Copy link
Collaborator

In the current design:

We have now overloaded showResult in the Training view with functionality unrelated to showing results. IMO we should abstract View.showResult to something like View.LongRunningTaskOnComplete which then calls showResultDialog and mainModel.training_complete.

However...

Our refactor plans include refactoring the entire LongRunningTask mechanism. So this info could be incorporated in our replacement, or it could end up being a mute point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant