Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an assistant is assigned to the "Best ..." language model, it's not properly using the best #592

Open
krschacht opened this issue Jan 13, 2025 · 5 comments
Milestone

Comments

@krschacht
Copy link
Contributor

I just tried assigning a newly created assistant to the "Best OpenAI Model" and it got an API error saying "openai-best" is not a recognized model name.

But our code used to be written such that openai-best is a placeholder model name and it gets substituted out for whichever model for this service has best = true. At some point we've broken this. I think this is a nice feature to support because people who are inclined to create many assistants are most likely to want to point them to the "best" one and then when you upgrade your language model to something newly released in the APIs you only have to update a single place.

Anyone want to take this one?
@mattlindsey @duckworth @papayalabs @drnic @voodoo @sergiobayona

@krschacht krschacht added this to the 0.7 milestone Jan 13, 2025
@krschacht
Copy link
Contributor Author

Also, maybe @draknor, @ceicke, @stephan-buckmaster, @jasonpaulso or @htruong if you might want to help with this one?

@stephan-buckmaster
Copy link
Contributor

I can look into this

@stephan-buckmaster
Copy link
Contributor

Looking at the code, when a language model is called "best", should its flags like supports-tools be taken from the "best" (according to the best flag) model?

@krschacht
Copy link
Contributor Author

Oh interesting: I think if language model named “best” is redirecting to a different model, then we should use the flags from the target model.

Maybe we should disable flags completely for these special models named “best” to avoid that confusion.

@stephan-buckmaster
Copy link
Contributor

Pull-request is #604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants