Replies: 1 comment
-
Yea, this is a good suggestion and surely an easy fix. I would have assumed navigating to another conversation would dismiss it so the fact that it’s not may actually be a change we need to make to turbo. I bet we need to render this within the turbo-frame of the conversation so then when that gets replaced this disappears. I originally had it auto dismiss after a certain number of seconds, but I found that tricky to tune the right thing and there was another case in the app I was putting something important in there (like an Undo link or something, I forget what). That’s what led me to remove auto dismiss and add an X. But it should be smarter about dismissing. |
Beta Was this translation helpful? Give feedback.
-
If I am deleting a conversation from the side-bar, the "Deleted Conversation" message is prominently shown and I need to manually confirm "X" for closing.
It's still shown, in case I navigate to another conversation. Couldn't this be automatically closed ?
I also think, this message doesn't provide any real benefit, because the specific conversation doesn't appear inside the sidebar anymore. Any additional message isn't neccessary.
I know this is a Rails standard message.
Beta Was this translation helpful? Give feedback.
All reactions