Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
no changelog
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR fixes an issue where Docker runtime containers were not being properly stopped when the application shuts down. The changes include:
Changes
Enhanced Shutdown Listener System:
shutdown_listener.py
that works better with Starlette/Uvicorn shutdown signalsatexit
handler with the new shutdown listener systemDocker Runtime Improvements:
_atexit_registered
flag andstop_all_runtime_containers
function_shutdown_listener_id
to track the shutdown listenerAdded Comprehensive Tests:
test_shutdown_listener.py
with thorough test coverageTechnical Details
This change ensures that Docker containers are properly cleaned up when the application exits, preventing orphaned containers from consuming system resources.
To run this PR locally, use the following command: